(#27) Escape PackageProperties elements #28
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On .Net fx, the PackageProperties elements have xml special chars
escaped. On Mono, they do not get escaped. mono/mono#21227
In the process of reading the nuspec metadata, escaped chars like "<"
get converted back into what they represent, for example "<". This is
not an issue on Windows, but is it an issue on Mono.
This manually escapes xml special chars from the PackageProperties
strings. The id and version are not escaped, as they cannot contain xml
special chars in the first place.
Fixes #27
How this PR was tested:
dust
package on both to validate that it will build on windows and fail on linuxdust
package on windows with the artifact from the previous step to validate that it still works.dust
package on linux with the artifact from the previous step to validate that this pr fixes the issue on Linux<
to each of thetitle
,authors
, andtags
elements in thedust.nuspec
on the Linux system