(#17) Replace slashes with underscores in the mutex's name #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gep13
changed the title
gep13
force-pushed
the
jsyeo-mutex-name
branch
2 times, most recently
from
f3546cb to
3b1e00a
Compare
These will be replaced with underscores. Mutex names must not contain a slash, since it's the namespace separator. There was a similar issue in NLog: NLog/NLog#1882 Where a similar change was made: https://github.com/NLog/NLog/pull/1930/files
gep13
force-pushed
the
jsyeo-mutex-name
branch
from
3b1e00a to
0703b6b
Compare
|
@jsyeo thank you very much for fixing this up! Really appreciate it! |
No worries, thanks for getting back to this and reviewing my code! 😘 |
46 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #17