Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support lifecycle, update Choco requirements #699

Merged
merged 1 commit into from
May 31, 2023

Conversation

vexx32
Copy link
Member

@vexx32 vexx32 commented Apr 19, 2023

Description Of Changes

  • Update Chocolatey CLI requirements
  • Added a new page that enumerates the support lifecycle and supported Windows versions
  • Add a link to MS docs on enabling TLS 1.2 on older operating systems to the troubleshooting page

Motivation and Context

As we get closer to v2.0, we need to update our support info and requirements for the new chocolatey versions.

Testing

  • I have previewed these changes using the Docker Container or another method before submitting this pull request.

Change Types Made

  • Minor documentation fix (typos etc.).
  • Major documentation change (refactoring, reformatting or adding documentation to existing page).
  • New documentation page added.
  • The change I have made should have a video added, and I have raised an issue for this.
    • Issue #

Change Checklist

  • Requires a change to menu structure (top or left hand side)/
  • Menu structure has been updated

Related Issue

Clickup

@vexx32 vexx32 requested review from gep13 and pauby April 19, 2023 21:04
@vexx32
Copy link
Member Author

vexx32 commented Apr 19, 2023

@gep13 @pauby

I checked through CLE and Agent pages, and neither of those currently mention required framework versions and so on. Should they? They essentially "inherit" the same supported frameworks and windows versions that CLI does, by virtue of CLI being required to be present before they can be installed or used. So I guess it's not necessary that they mention explicit requirements beyond the minimum Chocolatey versions, but it is a little odd to me that it doesn't really mention much there...

input/en-us/choco/setup.md Outdated Show resolved Hide resolved
input/en-us/choco/setup.md Outdated Show resolved Hide resolved
input/en-us/choco/setup.md Outdated Show resolved Hide resolved
input/en-us/choco/setup.md Outdated Show resolved Hide resolved
input/en-us/choco/setup.md Outdated Show resolved Hide resolved
input/en-us/information/support-lifecycle.md Outdated Show resolved Hide resolved
input/en-us/information/support-lifecycle.md Outdated Show resolved Hide resolved
input/en-us/troubleshooting.md Outdated Show resolved Hide resolved
input/en-us/troubleshooting.md Outdated Show resolved Hide resolved
input/en-us/troubleshooting.md Outdated Show resolved Hide resolved
@pauby pauby requested a review from ferventcoder April 21, 2023 14:41
@vexx32 vexx32 force-pushed the update-cli-requirements branch from 35ebd86 to 67cbb24 Compare April 21, 2023 18:27
@gep13
Copy link
Member

gep13 commented Apr 24, 2023

@vexx32 aside from the comment that @TheCakeIsNaOH has left, this looks good to me. I am assuming that this change will not be merged until we are ready to ship. Is that your understanding to?

@vexx32
Copy link
Member Author

vexx32 commented Apr 24, 2023

That makes sense to me, aye. 🙂

@vexx32 vexx32 force-pushed the update-cli-requirements branch from 67cbb24 to a17b4f8 Compare April 24, 2023 12:15
Copy link
Member

@pauby pauby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing that up @vexx32. Just a couple of small changes.

input/en-us/troubleshooting.md Outdated Show resolved Hide resolved
input/en-us/choco/setup.md Outdated Show resolved Hide resolved
@vexx32 vexx32 force-pushed the update-cli-requirements branch from a17b4f8 to 2001051 Compare April 25, 2023 15:43
input/en-us/choco/setup.md Outdated Show resolved Hide resolved
@vexx32 vexx32 force-pushed the update-cli-requirements branch from 2001051 to 2350dae Compare April 25, 2023 18:05
pauby
pauby previously approved these changes Apr 26, 2023
Copy link
Member

@ferventcoder ferventcoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, only a couple of things may need to be adjusted for clarity.

input/en-us/choco/setup.md Show resolved Hide resolved
input/en-us/choco/setup.md Show resolved Hide resolved
input/en-us/information/support-lifecycle.md Outdated Show resolved Hide resolved
input/en-us/information/support-lifecycle.md Outdated Show resolved Hide resolved
input/en-us/information/support-lifecycle.md Outdated Show resolved Hide resolved
input/en-us/information/support-lifecycle.md Outdated Show resolved Hide resolved
input/en-us/information/support-lifecycle.md Outdated Show resolved Hide resolved
@vexx32
Copy link
Member Author

vexx32 commented Apr 26, 2023

@ferventcoder I think I got everything updated from what you mentioned, thanks for the review! :3

@vexx32 vexx32 force-pushed the update-cli-requirements branch from b2def6e to 01f9368 Compare April 26, 2023 18:50
ferventcoder
ferventcoder previously approved these changes Apr 26, 2023
Copy link
Member

@ferventcoder ferventcoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for making those adjustments!

@vexx32
Copy link
Member Author

vexx32 commented May 10, 2023

Marking this as draft as we don't want it merged until closer to the v2 release.

@vexx32 vexx32 force-pushed the update-cli-requirements branch from 8daa265 to bc1c244 Compare May 30, 2023 20:23
@vexx32 vexx32 marked this pull request as ready for review May 30, 2023 21:23
@vexx32 vexx32 force-pushed the update-cli-requirements branch from bc1c244 to fa5f773 Compare May 31, 2023 13:29
Copy link
Member

@AdmiringWorm AdmiringWorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AdmiringWorm AdmiringWorm merged commit 328390a into chocolatey:master May 31, 2023
choco-bot pushed a commit that referenced this pull request May 31, 2023
Merge pull request #699 from vexx32/update-cli-requirements

Add support lifecycle, update Choco requirements
@vexx32 vexx32 deleted the update-cli-requirements branch May 31, 2023 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants