-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support lifecycle, update Choco requirements #699
Add support lifecycle, update Choco requirements #699
Conversation
I checked through CLE and Agent pages, and neither of those currently mention required framework versions and so on. Should they? They essentially "inherit" the same supported frameworks and windows versions that CLI does, by virtue of CLI being required to be present before they can be installed or used. So I guess it's not necessary that they mention explicit requirements beyond the minimum Chocolatey versions, but it is a little odd to me that it doesn't really mention much there... |
35ebd86
to
67cbb24
Compare
@vexx32 aside from the comment that @TheCakeIsNaOH has left, this looks good to me. I am assuming that this change will not be merged until we are ready to ship. Is that your understanding to? |
That makes sense to me, aye. 🙂 |
67cbb24
to
a17b4f8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing that up @vexx32. Just a couple of small changes.
a17b4f8
to
2001051
Compare
2001051
to
2350dae
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, only a couple of things may need to be adjusted for clarity.
2350dae
to
b2def6e
Compare
@ferventcoder I think I got everything updated from what you mentioned, thanks for the review! :3 |
b2def6e
to
01f9368
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks for making those adjustments!
Marking this as draft as we don't want it merged until closer to the v2 release. |
ff7456f
to
8daa265
Compare
8daa265
to
bc1c244
Compare
bc1c244
to
fa5f773
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Merge pull request #699 from vexx32/update-cli-requirements Add support lifecycle, update Choco requirements
Description Of Changes
Motivation and Context
As we get closer to v2.0, we need to update our support info and requirements for the new chocolatey versions.
Testing
Change Types Made
Change Checklist
Related Issue
Clickup