Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(#563) Add documentation about hooks #564

Merged
merged 1 commit into from
Nov 1, 2022
Merged

(#563) Add documentation about hooks #564

merged 1 commit into from
Nov 1, 2022

Conversation

TheCakeIsNaOH
Copy link
Member

@TheCakeIsNaOH TheCakeIsNaOH commented Oct 11, 2022 •
edited
Loading

Description Of Changes

Adds documentation about hooks

Motivation and Context

See #563

Should not be merged until hooks go out in a Chocolatey CLI release.

Testing

  • I have previewed these changes using the Docker Container or another method before submitting this pull request.

Change Types Made

  • Minor documentation fix (typos etc.).
  • Major documentation change (refactoring, reformatting or adding documentation to existing page).
  • New documentation page added.
  • The change I have made should have a video added, and I have raised an issue for this.
    • Issue #

Change Checklist

  • Requires a change to menu structure (top or left hand side)/
  • Menu structure has been updated

Related Issue

Fixes #563

@TheCakeIsNaOH TheCakeIsNaOH mentioned this pull request Oct 19, 2022
Closed
corbob
corbob previously requested changes Oct 19, 2022
View reviewed changes
Copy link
Member

@corbob corbob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few minor changes.

input/en-us/features/hook.md Outdated Show resolved Hide resolved
input/en-us/features/hook.md Outdated Show resolved Hide resolved
input/en-us/features/hook.md Outdated Show resolved Hide resolved
input/en-us/features/hook.md Outdated Show resolved Hide resolved
input/en-us/features/hook.md Outdated Show resolved Hide resolved
input/en-us/features/hook.md Outdated Show resolved Hide resolved
@TheCakeIsNaOH TheCakeIsNaOH requested a review from corbob October 27, 2022 01:41
@TheCakeIsNaOH TheCakeIsNaOH marked this pull request as ready for review October 27, 2022 01:41
@gep13 gep13 dismissed corbob’s stale review November 1, 2022 16:14

Requested changes have been implemented

gep13
gep13 approved these changes Nov 1, 2022
View reviewed changes
Copy link
Member

@gep13 gep13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gep13 gep13 merged commit 0f3a080 into chocolatey:master Nov 1, 2022
@gep13
Copy link
Member

gep13 commented Nov 1, 2022

@TheCakeIsNaOH this looks great! Thanks for getting this new page added, and for the hook feature in general!

choco-bot pushed a commit that referenced this pull request Nov 1, 2022
@web-flow
Continuous Integration Publish: 0f3a080
4575382 
Merge pull request #564 from TheCakeIsNaOH/hook-docs

(#563) Add documentation about hooks
@TheCakeIsNaOH TheCakeIsNaOH deleted the hook-docs branch November 17, 2022 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gep13 gep13 gep13 approved these changes

@corbob corbob Awaiting requested review from corbob

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add documentation for hook scripts.
3 participants
@TheCakeIsNaOH @gep13 @corbob