Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add AnchorJS links on <li> items beginning with <code> or <strong> children #798

Closed
2 tasks done
sync-by-unito bot opened this issue Jul 27, 2023 · 0 comments
Closed
2 tasks done

Add AnchorJS links on <li> items beginning with <code> or <strong> children #798

sync-by-unito bot opened this issue Jul 27, 2023 · 0 comments
Assignees
@st3phhays
Labels
4 - Done Code has been added to the repository, and has been reviewed by a team member Improvement Issues that enhances existing functionality, or adds new features

Comments

@sync-by-unito
Copy link

sync-by-unito bot commented Jul 27, 2023

Checklist

  • I have verified this is the correct repository for opening this issue.
  • I have verified no other issues exist related to my request.

Is Your Feature Request Related To A Problem? Please describe.

Sometimes in list items we have terms that we want to be able to navigate to with an anchor link, however this is currently not possible.

Describe The Solution. Why is it needed?

Any list item that contains a <strong> or a <code as the first element inside of a list item should have an anchor link added to it by AnchorJS. This is only for links that are inside the #mainContent or where AnchorJS is currently used (docs mostly).

Additional Context

This is primarily for the use in markdown.

Related Issues

No response

┆Issue is synchronized with this Github issue by Unito
@sync-by-unito sync-by-unito bot added 2 - Working A user or team member has started working on the issue Improvement Issues that enhances existing functionality, or adds new features labels Jul 27, 2023
@sync-by-unito sync-by-unito bot mentioned this issue Jul 27, 2023
Closed
2 tasks
st3phhays added a commit to st3phhays/docs that referenced this issue Jul 28, 2023
@st3phhays
(chocolatey#798) Add AnchorJS anchors to list items
529e5ae 
This adds anchors to list items that contain a <strong> or a <code>
node directly after an opening <li> tag. This is to make it easier to
navigate to these items, as often times this format is used more as a
"definition", or something we'd want to potentially link to.

No changes to current markdown is needed, as this intended to just
"work". All changes for this functionality live in choco-theme and will
be documented in the Choco Design System.
This was referenced Jul 28, 2023
Merged
Merged
Merged
st3phhays added a commit to st3phhays/docs that referenced this issue Jul 31, 2023
@st3phhays
(chocolatey#798) Add AnchorJS anchors to list items
3500569 
This adds anchors to list items that contain a <strong> or a <code>
node directly after an opening <li> tag. This is to make it easier to
navigate to these items, as often times this format is used more as a
"definition", or something we'd want to potentially link to.

No changes to current markdown is needed, as this intended to just
"work". All changes for this functionality live in choco-theme and will
be documented in the Choco Design System.
@sync-by-unito sync-by-unito bot added 3 - Review Code has been added, and is available for review as a pull request and removed 2 - Working A user or team member has started working on the issue labels Aug 1, 2023
st3phhays added a commit to st3phhays/docs that referenced this issue Aug 1, 2023
@st3phhays
(chocolatey#798) Add AnchorJS anchors to list items
bfc1b6e 
This adds anchors to list items that contain a <strong> or a <code>
node directly after an opening <li> tag. This is to make it easier to
navigate to these items, as often times this format is used more as a
"definition", or something we'd want to potentially link to.

No changes to current markdown is needed, as this intended to just
"work". All changes for this functionality live in choco-theme and will
be documented in the Choco Design System.
corbob added a commit that referenced this issue Aug 1, 2023
@corbob
Merge pull request #799 from st3phhays/anchors
e17a3c1 
(#798) Add AnchorJS anchors to list items
choco-bot pushed a commit that referenced this issue Aug 1, 2023
@web-flow
Continuous Integration Publish: e17a3c1
14b7908 
Merge pull request #799 from st3phhays/anchors

(#798) Add AnchorJS anchors to list items
@sync-by-unito sync-by-unito bot added 4 - Done Code has been added to the repository, and has been reviewed by a team member and removed 3 - Review Code has been added, and is available for review as a pull request labels Sep 5, 2023
@sync-by-unito sync-by-unito bot closed this as completed Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@st3phhays st3phhays

Labels
4 - Done Code has been added to the repository, and has been reviewed by a team member Improvement Issues that enhances existing functionality, or adds new features
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@st3phhays