(GH-878) Fixing install with packages.config - should print out the packages to install #880
Conversation
andmos
changed the title
|
Hello @andmos - thanks for your contribution! Please ensure you've read over CONTRIBUTING.md and please fix up your commit messages as directed in that document. We'll be looking for the two commits to squash to just one commit. The doc also mentions how to push the changes back up to this PR. Thanks! |
|
Also I noticed GitHub doesn't know how to associate your GH account with your commits. If that is not intentional, you may wish to set your username and user email in your git config :) |
|
It looks like he has his work mail in his config. He will need to add that email address to his github account. |
| @@ -362,6 +362,8 @@ | |||
| * should not have a successful package result for missing package | |||
| * should not have inconclusive package result | |||
| * should not have warning package result | |||
| * should print out package from config file in message | |||
| * should specify config file is beeing used in message | |||
There was a problem hiding this comment.
@andmos slight typo here. Should this be is being used
andmos
force-pushed
the
feature/anm-GH-878-print-packages-from-config-file
branch
2 times, most recently
from
2eca9d4 to
d078e5d
Compare
|
There, I have squashed the commits and added a more explanatory text to the commit message. |
andmos
force-pushed
the
feature/anm-GH-878-print-packages-from-config-file
branch
from
d078e5d to
f4d361c
Compare
|
andmos
force-pushed
the
feature/anm-GH-878-print-packages-from-config-file
branch
from
f4d361c to
ddc35ad
Compare
…file Previously when running choco install with a .config file as parameter the output would say ''Installing the following packages:'' followed by the path to the .config file. This change prints out that a .config file is being used, as well as listing the packages set for installation.
andmos
force-pushed
the
feature/anm-GH-878-print-packages-from-config-file
branch
from
ddc35ad to
2364f3f
Compare
|
Should be good now! |
|
Is this being looked at? I'm about to start writing PowerShell code that solves this issue in my installer script.. |
|
@bpjohannessen Yes. This is planned to go into 0.9.10.4 (vNext). |
|
@andmos There is only one bit of missing behavior. When the packages.config is not the only package name being passed. |
|
Merged into stable at 66b0107 |
Trying a fix for #878.
Added a check for
*.configfiles and added logging of the packages involved.Also logs that we actually install from a
*.configfile.Closes #878