(GH-769) API - Resolve Merged Assemblies #776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using the API, it should resolve merged assemblies but it may not if there is an assembly handler registered. Before loading up code that resolves external assemblies, register an AssemblyResolve handler with the purpose of determining if the assembly has Chocolatey's Public Key token or not. If it does, use Chocolatey's merged assembly instead of the conflicting assembly.
|
@RichiCoder1 can you take a look at this? I'm not sure if you can build it for testing though, since the keys will be different. |
|
Does this also include changes that cause all merged assemblies to have choco's public key? The issue was that choco was trying to activate a type that was in "System.Reactive.PlatformServices" with it's own public key and was picking up mine instead of the one in choco. |
| var requestedAssembly = new AssemblyName(args.Name); | ||
| if (requestedAssembly.get_public_key_token().is_equal_to(ApplicationParameters.OfficialChocolateyPublicKey)) | ||
| { | ||
| return typeof(Lets).Assembly; |
There was a problem hiding this comment.
@RichiCoder1 It's checking the public key token of the requested assembly - meaning that when choco is pulling an item is has merged in, the keys will match. So it will use the internal instead of an external conflicting Assembly. Does this answer your question?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the API, it should resolve merged assemblies but it may
not if there is an assembly handler registered. Before loading up
code that resolves external assemblies, register an AssemblyResolve
handler with the purpose of determining if the assembly has
Chocolatey's Public Key token or not. If it does, use Chocolatey's
merged assembly instead of the conflicting assembly.
Closes #769