(GH-616) Capture 7z's stdout in Get-ChocolateyUnzip #617
Conversation
Sometimes, Install-ChocolateyZipPackage and Get-ChocolateyUnzip capture files that don't belong to the package, record them in the <packagename>Install.zip.txt file, and cause them to be removed upon uninstallation by UnInstall-ChocolateyZipPackage. This fix uses 7z's standard output instead to determine which files belong to the package. This also avoids scanning possibly large directory trees.
| Add-Content $zipExtractLogFullPath $file | ||
| } | ||
| # Print the line, such that it looks as if stdout was not redirected | ||
| Write-Debug $line |
There was a problem hiding this comment.
Would you move this to Write-Verbose? This will help with #476
|
Overall 👍 |
Only print 7z's stdout in verbose mode, buffer the file list while writing to <packagename>Install.zip.txt, and don't create that file at all if the archive was empty.
|
Thanks for the quick feedback! I incorporated your suggestions in commit 4a2b56d. The file is written using a StringBuffer and a FileStream, and removed again if nothing was written at all. |
|
FileStream may have issues. |
|
Okay, what kind of issues? Should is change it to Add-Content? |
|
It may be fine. No worries |
| while(($process.StandardOutput -ne $null) -and (($line = $process.StandardOutput.ReadLine()) -ne $null)) { | ||
| if($line.StartsWith("Extracting")) { | ||
| # This is a line indicating an extracted file | ||
| $file = $destination + "\" + $line.Substring(12) |
There was a problem hiding this comment.
Nevermind, the two spaces after "Extracting".
There was a problem hiding this comment.
In 7z's output in the form "Extracting path\of\file\in\zip", the file path begins at character 12.
|
I changed this a bit to better match Start-ProcessAsAdmin (it was pretty close already). I think you'll find the perf quite sufficient. |
|
Thanks for your contribution! |
Sometimes, Install-ChocolateyZipPackage and Get-ChocolateyUnzip capture
files that don't belong to the package, record them in the
Install.zip.txt file, and cause them to be removed upon
uninstallation by UnInstall-ChocolateyZipPackage. This fix uses 7z's
standard output instead to determine which files belong to the package.
This also avoids scanning possibly large directory trees.
This commit should fix the issue GH-616.