Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(GH-595) Spelling mistakes #597

Closed
wants to merge 1 commit into from
Closed

Conversation

maharishi
Copy link
Contributor

@maharishi maharishi commented Jan 31, 2016

Changed spelling mistakes.

Closes #595

@ferventcoder ferventcoder changed the title Fix for bug #595 (GH-595) Spelling mistakes Jan 31, 2016
@ferventcoder
Copy link
Member

Did you submit this prior to reading over contributing or receiving my advice about reading it to save you pain later?

@ferventcoder
Copy link
Member

Please read over https://github.com/chocolatey/choco/blob/master/CONTRIBUTING.md and make the adjustments to the commit message. :)

@ferventcoder
Copy link
Member

@maharishi specifically https://github.com/chocolatey/choco/blob/master/CONTRIBUTING.md#prepare-commits and https://github.com/chocolatey/choco/blob/master/CONTRIBUTING.md#respond-to-feedback-on-pull-request because you are going to need these now.

Also, I see you submitted the PR from your master branch. We like all PRs to come from a feature branch, as documented in the contributing document I asked you to read. I know it looks like a wall of text, but it's very detailed in our expectations. And makes for less pain on your part later.

@ferventcoder ferventcoder changed the title (GH-595) Spelling mistakes {WIP}(GH-595) Spelling mistakes Jan 31, 2016
@ferventcoder
Copy link
Member

Ping @maharishi

@ferventcoder
Copy link
Member

@maharishi Have you had a chance to review the feedback I provided? If you don't want to fix this PR up, let me know and I will go ahead and just make the change and close this PR. Thanks!

@ferventcoder ferventcoder changed the title {WIP}(GH-595) Spelling mistakes (GH-595) Spelling mistakes Jul 24, 2016
@ferventcoder
Copy link
Member

Fixed up and merged into stable at fdf3fbf.

Thanks for the contribution! Now we'll just need to ensure you are getting the messages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants