(GH-468) Send Chocolatey Command Help to standard out not Err #549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commands such as:
choco list -help | more
choco list -help | out-host -paging
...did not page as expected.
Similarly:
choco -help | out-file HelpDetails.txt
did not deliver all of the help output to the file.
(The workaround of using 2>&1 (or *>&1) is burdensome for the very
people who need help in the first place.)
So, in line with normal use of NDesk OptionSet, the option descriptions
are now written to Console.Out not Console.Error.
|
|
||
| public override void Context() | ||
| { | ||
| ConfigurationOptions.initialize_with(new Lazy<IConsole>(() => console.Object)); | ||
| ConfigurationOptions.reset_options(); | ||
| console.Setup((c) => c.Error).Returns(writer); | ||
| console.Setup((c) => c.Error).Returns(errorWriter); | ||
| console.Setup((c) => c.Out).Returns(outputWriter); |
|
Looks good, thanks! |
|
Rebased and merged into stable at d9d59ff |
|
Thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commands such as:
choco list -help | more
choco list -help | out-host -paging
...did not page as expected.
Similarly:
choco -help | out-file HelpDetails.txt
did not deliver all of the help output to the file.
(The workaround of using 2>&1 (or *>&1) is burdensome for the very
people who need help in the first place.)
So, in line with normal use of NDesk OptionSet, the option descriptions
are now written to Console.Out not Console.Error.
Closes #468