(GH-510) Fix for Choco new silentargs can't pass in args in the param… #513
Conversation
… the param=value format
|
@sahebjade Have you had the opportunity to review our CONTRIBUTING document? We would ask that you read over and sign a CLA so that we can take contributions - https://github.com/chocolatey/choco/blob/master/CONTRIBUTING.md Apologies, usually the CLA bot check shows up on PRs, but it appears it did not for this PR. |
|
Now it looks like it may be incorrectly flagging as signed. Looks like we may need to find another CLA host |
| @@ -79,7 +79,7 @@ public void handle_additional_argument_parsing(IList<string> unparsedArguments, | |||
|
|
|||
| foreach (var unparsedArgument in unparsedArguments.or_empty_list_if_null()) | |||
| { | |||
| var property = unparsedArgument.Split(new[] {'='}, StringSplitOptions.RemoveEmptyEntries); | |||
| var property = unparsedArgument.Split(new[] { '=' }, 2, StringSplitOptions.RemoveEmptyEntries); | |||
|
Followup @sahebjade, it appears the CLA has not yet been signed. I mentioned this above in #513 (comment). The status is showing incorrectly here as I resent those through and it didn't pick up the original submitter of this request. If you can review and sign, we can move forward with this fix. |
|
Sorry I was away from work. Now I have signed the CLA. Please can you move it further. Thanks. |
…=value format
Closes #510