(GH-14) alternative sources

src/chocolatey.console/Program.cs

@@ -183,7 +183,7 @@ private static void remove_old_chocolatey_exe(IFileSystem fileSystem)
         {
             try
             {
-                fileSystem.delete_file(Assembly.GetExecutingAssembly().CodeBase.Replace("file:///", string.Empty) + ".old");
+                fileSystem.delete_file(fileSystem.get_current_assembly_path() + ".old");
                 fileSystem.delete_file(fileSystem.combine_paths(AppDomain.CurrentDomain.BaseDirectory, "choco.exe.old"));
             }
             catch (Exception ex)

src/chocolatey.tests.integration/NUnitSetup.cs

@@ -57,7 +57,7 @@ private static void fix_application_parameter_variables(Container container)
         {
             var fileSystem = container.GetInstance<IFileSystem>();
 
-            var applicationLocation = fileSystem.get_directory_name(Assembly.GetExecutingAssembly().CodeBase.Replace("file:///", string.Empty));
+            var applicationLocation = fileSystem.get_directory_name(fileSystem.get_current_assembly_path());
 
             var field = typeof (ApplicationParameters).GetField("InstallLocation");
             field.SetValue(null, applicationLocation);

src/chocolatey.tests.integration/Scenario.cs

@@ -35,7 +35,7 @@ public class Scenario
 
         public static string get_top_level()
         {
-            return _fileSystem.get_directory_name(Assembly.GetExecutingAssembly().CodeBase.Replace("file:///", string.Empty));
+            return _fileSystem.get_directory_name(_fileSystem.get_current_assembly_path());
         }
 
         public static string get_package_install_path()

src/chocolatey.tests.integration/infrastructure/commands/CommandExecutorSpecs.cs

@@ -47,7 +47,7 @@ public override void Context()
 
             public override void Because()
             {
-                result = CommandExecutor.execute("cmd.exe", "/c bob123123", ApplicationParameters.DefaultWaitForExitInSeconds, fileSystem.get_current_directory(), null, (s, e) => { errorOutput += e.Data; }, updateProcessPath: false);
+                result = commandExecutor.execute("cmd.exe", "/c bob123123", ApplicationParameters.DefaultWaitForExitInSeconds, fileSystem.get_current_directory(), null, (s, e) => { errorOutput += e.Data; }, updateProcessPath: false);
             }
 
             [Fact]

src/chocolatey.tests.integration/infrastructure/cryptography/CrytpoHashProviderSpecs.cs

@@ -35,7 +35,7 @@ public override void Context()
             {
                 FileSystem = new DotNetFileSystem();
                 Provider = new CrytpoHashProvider(FileSystem,CryptoHashProviderType.Md5);
-                ContextDirectory = FileSystem.combine_paths(FileSystem.get_directory_name(Assembly.GetExecutingAssembly().CodeBase.Replace("file:///", string.Empty)), "context");
+                ContextDirectory = FileSystem.combine_paths(FileSystem.get_directory_name(FileSystem.get_current_assembly_path()), "context");
             }
         }
 

src/chocolatey.tests.integration/infrastructure/filesystem/DotNetFileSystemSpecs.cs

@@ -21,6 +21,7 @@ namespace chocolatey.tests.integration.infrastructure.filesystem
     using NUnit.Framework;
     using Should;
     using chocolatey.infrastructure.filesystem;
+    using chocolatey.infrastructure.platforms;
 
     public class DotNetFileSystemSpecs
     {
@@ -48,6 +49,53 @@ public override void Context()
             }
         }
 
+        [Category("Integration")]
+        public class when_finding_paths_to_executables_with_dotNetFileSystem : DotNetFileSystemSpecsBase
+        {
+            public override void Because()
+            {
+            }
+
+            [Fact]
+            public void GetExecutablePath_should_find_existing_executable()
+            {
+                FileSystem.get_executable_path("cmd").ShouldEqual(
+                    Platform.get_platform() == PlatformType.Windows ?
+                        "C:\\Windows\\system32\\cmd.exe"
+                        : "cmd"
+                    );
+            }
+
+            [Fact]
+            public void GetExecutablePath_should_find_existing_executable_with_extension()
+            {
+                FileSystem.get_executable_path("cmd.exe").ShouldEqual(
+                    Platform.get_platform() == PlatformType.Windows ?
+                        "C:\\Windows\\system32\\cmd.exe"
+                        : "cmd"
+                    );
+            }
+
+            [Fact]
+            public void GetExecutablePath_should_return_same_value_when_executable_is_not_found()
+            {
+                FileSystem.get_executable_path("daslakjsfdasdfwea").ShouldEqual("daslakjsfdasdfwea");
+            }
+
+            [Fact]
+            public void GetExecutablePath_should_return_empty_string_when_value_is_null()
+            {
+                FileSystem.get_executable_path(null).ShouldEqual(string.Empty);
+            }
+
+            [Fact]
+            public void GetExecutablePath_should_return_empty_string_when_value_is_empty_string()
+            {
+                FileSystem.get_executable_path(string.Empty).ShouldEqual(string.Empty);
+            }
+
+        }
+
         [Category("Integration")]
         public class when_doing_file_system_operations_with_dotNetFileSystem : DotNetFileSystemSpecsBase
         {

src/chocolatey.tests/chocolatey.tests.csproj

@@ -80,6 +80,7 @@
     <Compile Include="infrastructure.app\services\AutomaticUninstallerServiceSpecs.cs" />
     <Compile Include="infrastructure.app\services\FilesServiceSpecs.cs" />
     <Compile Include="infrastructure.app\services\NugetServiceSpecs.cs" />
+    <Compile Include="infrastructure.app\services\RegistryServiceSpecs.cs" />
     <Compile Include="infrastructure\commands\ExternalCommandArgsBuilderSpecs.cs" />
     <Compile Include="infrastructure\commandline\InteractivePromptSpecs.cs" />
     <Compile Include="infrastructure\commands\CommandExecutorSpecs.cs" />

src/chocolatey.tests/infrastructure.app/services/AutomaticUninstallerServiceSpecs.cs

@@ -77,7 +77,7 @@ public override void Context()
                 packageResults.GetOrAdd("regular", packageResult);
 
                 fileSystem.Setup(f => f.directory_exists(registryKeys.FirstOrDefault().InstallLocation)).Returns(true);
-                registryService.Setup(r => r.value_exists(registryKeys.FirstOrDefault().KeyPath, ApplicationParameters.RegistryValueInstallLocation)).Returns(true);
+                registryService.Setup(r => r.installer_value_exists(registryKeys.FirstOrDefault().KeyPath, ApplicationParameters.RegistryValueInstallLocation)).Returns(true);
                 fileSystem.Setup(f => f.get_full_path(expectedUninstallString)).Returns(expectedUninstallString);
             }
         }
@@ -235,7 +235,7 @@ public override void Context()
             {
                 base.Context();
                 registryService.ResetCalls();
-                registryService.Setup(r => r.value_exists(registryKeys.FirstOrDefault().KeyPath, ApplicationParameters.RegistryValueInstallLocation)).Returns(false);
+                registryService.Setup(r => r.installer_value_exists(registryKeys.FirstOrDefault().KeyPath, ApplicationParameters.RegistryValueInstallLocation)).Returns(false);
             }
 
             public override void Because()
@@ -264,7 +264,7 @@ public override void Context()
                 fileSystem.ResetCalls();
                 fileSystem.Setup(f => f.directory_exists(registryKeys.FirstOrDefault().InstallLocation)).Returns(false);
                 registryService.ResetCalls();
-                registryService.Setup(r => r.value_exists(registryKeys.FirstOrDefault().KeyPath, ApplicationParameters.RegistryValueInstallLocation)).Returns(false);
+                registryService.Setup(r => r.installer_value_exists(registryKeys.FirstOrDefault().KeyPath, ApplicationParameters.RegistryValueInstallLocation)).Returns(false);
             }
 
             public override void Because()

src/chocolatey.tests/infrastructure.app/services/RegistryServiceSpecs.cs

@@ -0,0 +1,150 @@
+// Copyright © 2011 - Present RealDimensions Software, LLC
+// 
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// 
+// You may obtain a copy of the License at
+// 
+// 	http://www.apache.org/licenses/LICENSE-2.0
+// 
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+namespace chocolatey.tests.infrastructure.app.services
+{
+    using System;
+    using Microsoft.Win32;
+    using Moq;
+    using Should;
+    using chocolatey.infrastructure.app.services;
+    using chocolatey.infrastructure.filesystem;
+    using chocolatey.infrastructure.services;
+    using Registry = chocolatey.infrastructure.app.domain.Registry;
+
+    public class RegistryServiceSpecs
+    {
+        public abstract class RegistryServiceSpecsBase : TinySpec
+        {
+            protected RegistryService Service;
+            protected Mock<IFileSystem> FileSystem = new Mock<IFileSystem>();
+            protected Mock<IXmlService> XmlService = new Mock<IXmlService>();
+
+            public override void Context()
+            {
+                reset();
+                Service = new RegistryService(XmlService.Object, FileSystem.Object);
+            }
+
+            protected void reset()
+            {
+                FileSystem.ResetCalls();
+                XmlService.ResetCalls();
+                MockLogger.reset();
+            }
+        }
+
+
+
+        public class when_RegistryService_get_installer_keys_is_called : RegistryServiceSpecsBase
+        {
+            private Registry _result;
+
+            public override void Context()
+            {
+                base.Context();
+            }
+
+            public override void Because()
+            {
+                _result = Service.get_installer_keys();
+            }
+
+
+            [Fact]
+            public void should_not_be_null()
+            {
+                _result.ShouldNotBeNull();
+            }
+
+        }
+
+        public class when_RegistryService_get_key_is_called_for_a_value_that_exists : RegistryServiceSpecsBase
+        {
+            //todo does any of this test correctly on *nix?
+
+            private RegistryKey _result;
+            private RegistryHive _hive = RegistryHive.CurrentUser;
+            private string _subkeyPath = "Console";
+
+            public override void Context()
+            {
+                base.Context();
+            }
+
+            public override void Because()
+            {
+                _result = Service.get_key(_hive, _subkeyPath);
+            }
+
+            [Fact]
+            public void should_return_a_non_null_value()
+            {
+               _result.ShouldNotBeNull();
+            } 
+
+            [Fact]
+            public void should_return_a_value_of_type_RegistryKey()
+            {
+               _result.ShouldBeType<RegistryKey>();
+            }
+
+            [Fact]
+            public void should_contain_keys()
+            {
+                _result.GetSubKeyNames().ShouldNotBeEmpty();
+            }
+
+            [Fact]
+            public void should_contain_values()
+            {
+                _result.GetValueNames().ShouldNotBeEmpty();
+            }
+        } 
+
+        public class when_RegistryService_get_key_is_called_for_a_value_that_does_not_exist : RegistryServiceSpecsBase
+        {
+            //todo does any of this test correctly on *nix?
+
+            private RegistryKey _result;
+            private RegistryHive _hive = RegistryHive.CurrentUser;
+            private string _subkeyPath = "Software\\alsdjfalskjfaasdfasdf";
+
+            public override void Context()
+            {
+                base.Context();
+            }
+
+            public override void Because()
+            {
+                _result = Service.get_key(_hive, _subkeyPath);
+            }
+
+            [Fact]
+            public void should_not_error()
+            {
+                //nothing to see here
+            }
+
+            [Fact]
+            public void should_return_null_key()
+            {
+                _result.ShouldBeNull();
+            }
+        }
+
+        //todo a subkey that exists only in 32 bit mode (must create it to test it though)
+    }
+}