(GH-338) Delete read only files #377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ferventcoder
changed the title
Ensure file attribute set is ignoring the attributes passed in and only looking at Hidden. Fix that to use the attributes passed in.
Add the following methods to IFileSystem - ensure_file_attribute_removed - is_readonly_file - is_hidden_file - delete_directory overriding attributes - delete_directory_if_exists overriding attributes
Enhance IFilesService to look at a package and clean up the attributes of all files in the package. Also refactor some of the methods to use the same install location verification.
When performing install/upgrade/uninstall, ensure that the attributes in the package files do not cause the action to fail. Remove ReadOnly, Hidden, and System attributes if found from any files in the package.
- DotNetFileSystem.when_setting_file_attributes_with_dotNetFileSystem - DotNetFileSystem.when_removing_readonly_attributes_with_dotNetFileSystem - UpgradeScenarios.when_upgrading_a_package_with_readonly_files - UninstallScenarios.when_uninstalling_a_package_with_readonly_files
ferventcoder
force-pushed
the
readonly
branch
from
9430d88 to
61a6dfc
Compare
ferventcoder
changed the title
ferventcoder
added a commit
that referenced
this pull request
Sep 17, 2015
(GH-338) Delete read only files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #338