(#3242) Attempt default credentials for sources #3252
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
Attempt to use the default credentials for the first attempt at a source.
Important note of behaviour change: If we are not able to authenticate with a source, we now prompt 3 times instead of 4, and the first one is prefaced with an
Invalid credentials specified
warning.Motivation and Context
When attempting a query to a source that requires credentials, we were always prompting for credentials. This prevents attempting the default credentials unless entering an empty password. We should attempt initially with the default credentials, and only prompt if it's a retry for credentials.
Testing
Automated test suite:
./Invoke-AuthedTests.ps1
scriptSome output screenshots of the authenticated tests without username/password provided:
Operating Systems Testing
Change Types Made
Change Checklist
Related Issue
Fixes #3242