Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(maint) Fix incorrect naming style uses #3233

Merged
merged 1 commit into from
Jun 30, 2023

Conversation

AdmiringWorm
Copy link
Member

Description Of Changes

A while back we started implementing a standard of the naming style
that is meant to be followed in the repository.
At that time not everything was renamed to follow this new naming style,
and this change attempts to update all remaining items that hadn't been
renamed.

Motivation and Context

To be consistent across the entire codebase.

Testing

  1. Other than running .\build.ps1 the changes has not been tested as there are no functional changes.

With the above said, it may be a good idea to run test kitchen for CLI for this PR before merging.

Operating Systems Testing

  • Windows 10

Change Types Made

  • Bug fix (non-breaking change).
  • Feature / Enhancement (non-breaking change).
  • Breaking change (fix or feature that could cause existing functionality to change).
  • Documentation changes.
  • PowerShell code changes.
  • Maintenance changes

Change Checklist

  • Requires a change to the documentation.
  • Documentation has been updated.
  • Tests to cover my changes, have been added.
  • All new and existing tests passed?
  • PowerShell code changes: PowerShell v2 compatibility checked?

Related Issue

N/A

@AdmiringWorm
Copy link
Member Author

This PR is in draft until v2.1.0 is released.

@AdmiringWorm AdmiringWorm self-assigned this Jun 28, 2023
A while back we started implementing a standard of the naming style
that is meant to be followed in the repository.
At that time not everything was renamed to follow this new naming style,
and this change attempts to update all remaining items that hadn't been
renamed.
@AdmiringWorm AdmiringWorm marked this pull request as ready for review June 30, 2023 10:49
@AdmiringWorm AdmiringWorm requested a review from gep13 June 30, 2023 10:49
Copy link
Member

@gep13 gep13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gep13 gep13 merged commit d836138 into chocolatey:develop Jun 30, 2023
@gep13
Copy link
Member

gep13 commented Jun 30, 2023

@AdmiringWorm thank you very much for getting this updated! This very much needed to be done!

@AdmiringWorm AdmiringWorm deleted the nameing-styles branch June 30, 2023 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants