Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix grammar in the pending reboot warning message #3164

Merged
merged 1 commit into from
Apr 19, 2024

Conversation

sorousherafat
Copy link
Contributor

Description Of Changes

Changed 'Pending Reboot' warning message to be more accurate grammatically.

Motivation and Context

Testing

Operating Systems Testing

Change Types Made

  • Bug fix (non-breaking change).
  • Feature / Enhancement (non-breaking change).
  • Breaking change (fix or feature that could cause existing functionality to change).
  • Documentation changes.
  • PowerShell code changes.

Change Checklist

  • Requires a change to the documentation.
  • Documentation has been updated.
  • Tests to cover my changes, have been added.
  • All new and existing tests passed?
  • PowerShell code changes: PowerShell v2 compatibility checked?

Related Issue

Fixes no issue

@CLAassistant
Copy link

CLAassistant commented May 20, 2023

CLA assistant check
All committers have signed the CLA.

pauby
pauby previously requested changes Apr 19, 2024
Copy link
Member

@pauby pauby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel this reads better.

@gep13 gep13 force-pushed the reboot-required-message branch from d148228 to 48d23aa Compare April 19, 2024 11:52
@gep13 gep13 added this to the 2.3.0 milestone Apr 19, 2024
@gep13
Copy link
Member

gep13 commented Apr 19, 2024

@sorousherafat thank you very much for taking the time to raise this PR to highlight this problem. After discussing with @pauby we are going to move forward with his suggestion, and I have taken the liberty to update this PR with his suggestions.

@gep13 gep13 dismissed pauby’s stale review April 19, 2024 11:54

The suggestion made has been applied.

@gep13
Copy link
Member

gep13 commented Apr 19, 2024

Not sure why the CLA check is being marked as not there:

image

but it has been signed, as per this comment:

#3164 (comment)

Copy link
Member

@gep13 gep13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gep13 gep13 merged commit 032bafb into chocolatey:develop Apr 19, 2024
4 checks passed
@gep13 gep13 changed the title (maint) Fix grammatical issue in pending reboot warning message Fix grammatical issue in pending reboot warning message May 24, 2024
@pauby pauby changed the title Fix grammatical issue in pending reboot warning message Fix grammar in the pending reboot warning message May 28, 2024
@choco-bot
Copy link

🎉 This issue has been resolved in version 2.3.0 🎉

The release is available on:

Your GitReleaseManager bot 📦 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants