Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(maint) Remove nuspec prerelease warnings #3155

Merged
merged 1 commit into from
May 12, 2023
Merged

(maint) Remove nuspec prerelease warnings #3155

merged 1 commit into from
May 12, 2023

Conversation

vexx32
Copy link
Member

@vexx32 vexx32 commented May 12, 2023 •
edited by gep13
Loading

Description Of Changes

Removed some warnings about prerelease versions and known issues links from the nuspec

Motivation and Context

Won't be relevant any longer once the v2 release is up.

Testing

  1. Build the packages.
  2. Inspect the nupkg and ensure the nuspec description doesn't contain the prerelease / known issues warnings.

Operating Systems Testing

N/A

Change Types Made

  • Bug fix (non-breaking change).
  • Feature / Enhancement (non-breaking change).
  • Breaking change (fix or feature that could cause existing functionality to change).
  • Documentation changes.
  • PowerShell code changes.

Change Checklist

  • Requires a change to the documentation.
  • Documentation has been updated.
  • Tests to cover my changes, have been added.
  • All new and existing tests passed?
  • PowerShell code changes: PowerShell v2 compatibility checked?

Related Issue

N/A, these were only here for the prerelease alpha/beta versions.

@vexx32
(maint) Remove prerelease warnings from the nuspec
aa4b6b2 
These warnings are no longer relevant as we're looking to do the final
release soon(tm).
@vexx32 vexx32 requested a review from gep13 May 12, 2023 15:51
@corbob corbob changed the base branch from develop to release/2.0.0 May 12, 2023 16:25
gep13
gep13 approved these changes May 12, 2023
View reviewed changes
Copy link
Member

@gep13 gep13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gep13 gep13 merged commit 2175d3e into chocolatey:release/2.0.0 May 12, 2023
@gep13
Copy link
Member

gep13 commented May 12, 2023

@vexx32 thanks for getting this fixed up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gep13 gep13 gep13 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vexx32 @gep13