Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(maint) Update Gitreleasemanager configuration #3031

Merged
merged 1 commit into from
Feb 20, 2023

Conversation

vexx32
Copy link
Member

@vexx32 vexx32 commented Feb 15, 2023

Description Of Changes

  • Added the Deprecate label to GRM configuration.
  • Added config to set headers in the release notes specifically for Deprecate and Bug so that their headers match our release notes format.
    NOTE: We should cherry-pick this commit into support/1.x branch after it's merged as well.

Motivation and Context

We're deprecating quite a few things, we should probably use a proper label for it.

Also, the auto-gen'd release notes don't quite match our release notes format, so updated the config to make that work as expected.

Testing

Ran ./build.ps1 -Target releasenotes from the support/1.x branch with this configuration change and verified the generated release notes match up to what we want.

Operating Systems Testing

N/A

Change Types Made

  • Bug fix (non-breaking change).
  • Feature / Enhancement (non-breaking change).
  • Breaking change (fix or feature that could cause existing functionality to change).
  • Documentation changes.
  • PowerShell code changes.
  • Build enhancement

Change Checklist

  • Requires a change to the documentation.
  • Documentation has been updated.
  • Tests to cover my changes, have been added.
  • All new and existing tests passed?
  • PowerShell code changes: PowerShell v2 compatibility checked?

Related Issue

N/A, build adjustment only

@vexx32 vexx32 requested a review from gep13 February 15, 2023 15:32
gitreleasemanager.yaml Outdated Show resolved Hide resolved
@gep13 gep13 force-pushed the update-gitreleasemanager-config branch from 4279e5f to e2b05e0 Compare February 20, 2023 20:04
- Added the Deprecate label to GRM configuration.
- Added config to set headers in the release notes specifically for
  Deprecate and Bug so that their headers match our release notes
  format.
@gep13 gep13 force-pushed the update-gitreleasemanager-config branch from e2b05e0 to 8a83d52 Compare February 20, 2023 20:06
@gep13 gep13 merged commit b63d810 into chocolatey:develop Feb 20, 2023
@gep13
Copy link
Member

gep13 commented Feb 20, 2023

@vexx32 thanks for getting this updated!

@vexx32 vexx32 deleted the update-gitreleasemanager-config branch February 21, 2023 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants