(#1185) Add original powershell host run as deprecated method #2831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Task linked: ENGTASKS-1480 Chocolatey CLI |
Changing the interface or public methods are breaking changes which we need to wait with implementing before the next major release. As such, this commit adds back the old way of running the powershell host by adding an overload with the original contract for the interface that could possibly be used in other projects that makes use of the Chocolatey.Lib library. This overload has been made obsolete and will just call the new method while setting any hook scripts as empty enumerables.
AdmiringWorm
force-pushed
the
deprecate-old-run-host
branch
from
506b201 to
96b9ebe
Compare
|
Thanks for spotting this and getting it fixed up @AdmiringWorm! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
This pull request updates the PowershellService class and interface to re-add the original
run_hostmethod to prevent the need to do a breaking release.Motivation and Context
We need to keep the old method contract around until we create a new breaking major release of Chocolatey CLI so it will be backwards compatible with other projects we own, or projects that make use of the Chocolatey.Lib API library.
Testing
Change Types Made
Related Issue
#1185
https://app.clickup.com/t/20540031/ENGTASKS-1480
Change Checklist