(maint) PowerShell Formatting

[TheCakeIsNaOH]

Description Of Changes

PowerShell formatting changes according to PSSA settings in chocolatey/Chocolatey.Cake.Recipe#73.

Motivation and Context

Brings the PowerShell scripts to a consistent formatting baseline in this repository to prepare for #2703.

The chocolateyInstall.ps1 in the zip.template and msi.template packages included for the pester tests will give parsing errors, these will need to be excluded. The parsing errors are due to the tokens that are to be replaced when the template is used.

The tools directory also need to be excluded as it contains PowerShell scripts from various Cake modules/tools/addins/etc that should not be checked.

Testing

Ran Invoke-ScriptAnalyzer -Path . -Recurse -Settings "\path\to\Chocolatey.Cake.Recipe\Chocolatey.Cake.Recipe\Content\formatting-settings.psd1" to ensure that the PowerShell formatting is acceptable according to the agreed on settings.
Ran nunit and pester tests to ensure that nothing was broken.

Change Types Made

• Bug fix (non-breaking change)
• Feature / Enhancement (non-breaking change)
• Breaking change (fix or feature that could cause existing functionality to change)
• PowerShell code changes.
• Maint

Related Issue

Formatting changes for #2703
Part of #13

Change Checklist

• Requires a change to the documentation
• Documentation has been updated
• Tests to cover my changes, have been added
• All new and existing tests passed.
• PowerShell v2 compatibility checked.

[coveralls]

Coverage remained the same at 28.668% when pulling 1f2d60c on TheCakeIsNaOH:pssa-formatting into 1f34adf on chocolatey:develop.

[vexx32]

This looks good to me! A few comments here and there. There's more we could do with these scripts going forward, but this is a great first step.

Thanks for the PR! 💖 😊

[gep13]

LGTM!

[gep13]

@TheCakeIsNaOH thanks for getting all of these fixed up!