(#2738) Uplift to .Net 4.8 #2739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheCakeIsNaOH
force-pushed
the
uplift-framework
branch
4 times, most recently
from
ea1562f to
acd5517
Compare
TheCakeIsNaOH
force-pushed
the
uplift-framework
branch
3 times, most recently
from
907f0c7 to
065c4d6
Compare
TheCakeIsNaOH
force-pushed
the
uplift-framework
branch
2 times, most recently
from
cae7191 to
7e8516f
Compare
TheCakeIsNaOH
force-pushed
the
uplift-framework
branch
from
7e8516f to
8487d6e
Compare
gep13
force-pushed
the
uplift-framework
branch
2 times, most recently
from
e6a1dff to
3b2fb7c
Compare
Closed
These tests are broken by running on .Net 4.8, see issue chocolatey#2690 They are being skipped so the integration test run passes.
Now that it is building on a newer .Net version, it is not required to specify the version explicitly, as it can be autodetected.
Updated the location of the system DLLs for the updated .NET version.
There has been a change in how GetCustomAttribute works between .NET 4.0 and .NET 4.8. Previously, this worked without any problems, but in .NET 4.8, it errors with a message regarding duplicate types found. In order to work around this, we make use of GetCustomAttributes and then filter the list from there, as/when required.
gep13
force-pushed
the
uplift-framework
branch
from
3b2fb7c to
80f69dd
Compare
|
@TheCakeIsNaOH thank you very much for taking the time to do this work! This has been a long time coming, but we are ready to start making our way towards this goal! I have made a couple of changes to the files within this PR, as there were some changes required as a result of the work that was done in 1.2.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
TODO
Motivation and Context
TODO
Testing
TODO
Change Types Made
Related Issue
Fixes #2738
Change Checklist