Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(#2650) Upgrade 7z to 21.07 #2662

Merged
merged 1 commit into from
Mar 28, 2022
Merged

(#2650) Upgrade 7z to 21.07 #2662

merged 1 commit into from
Mar 28, 2022

Conversation

gep13
Copy link
Member

@gep13 gep13 commented Mar 25, 2022

Description Of Changes

Upgrade to latest 7zip binaries.

Motivation and Context

There are no CVE's associated with the previous release, however, since
the last version was shipped in 2018, it was decided to upgrade to a
newer version.

Testing

  1. Built new nupkg with changes in this PR
  2. Installed onto machine for testing
  3. Installed the sqlite package (which includes usage of the Get-ChocolateyUnZip cmdlet)
  4. Verified that it installed as expected, with no errors

Change Types Made

  • Bug fix (non-breaking change)
  • Feature / Enhancement (non-breaking change)
  • Breaking change (fix or feature that could cause existing functionality to change)

Related Issue

Fixes #2650

Change Checklist

  • Requires a change to the documentation
  • Documentation has been updated
  • Tests to cover my changes, have been added
  • All new and existing tests passed.

@gep13 gep13 requested review from corbob and vexx32 March 25, 2022 11:45
@gep13
Copy link
Member Author

gep13 commented Mar 25, 2022

If/when this is merged, a follow up PR to CCR will be required to bump the 7za.exe that is stored there to be the same version, so that everything is consistent.

Copy link
Member

@corbob corbob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've taken this for a spin with the Intune integration, it's all working as expected. I'm just running a test kitchen run against it, will know before Monday if there's any issues with those tests.

@corbob
Copy link
Member

corbob commented Mar 26, 2022

Well that didn't go quite as planned...

2022-03-26_08-46-43

Those 15 failed are expected due to the build identifying as `0.12.1-alpha` and those tests only skipping if the version is 1.0.0 or greater. (those tests being that we're reporting the existence of the version command which is gone)

There are no CVE's associated with the previous release, however, since
the last version was shipped in 2018, it was decided to upgrade to a
newer version.
@gep13
Copy link
Member Author

gep13 commented Mar 28, 2022

@corbob thanks for taking this for a spin!

@gep13 gep13 merged commit a30fa79 into chocolatey:develop Mar 28, 2022
@gep13 gep13 deleted the bump-7zip branch March 28, 2022 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include the latest version of 7zip (v21.07) within Chocolatey installation
2 participants