Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(#2443) Fix misspellings for profile text #2654

Merged
merged 1 commit into from
Mar 15, 2022

Conversation

vexx32
Copy link
Member

@vexx32 vexx32 commented Mar 14, 2022

Description Of Changes

Fixed a couple minor misspellings in the comments we're adding to folks' profiles in the Chocolatey install.

Motivation and Context

Noticed it in the testing, figured we may as well fix it.

Testing

N/A, only code comments edited.

Change Types Made

  • Doc/comments updated
  • Bug fix (non-breaking change)
  • Feature / Enhancement (non-breaking change)
  • Breaking change (fix or feature that could cause existing functionality to change)
  • PowerShell code changes.

Related Issue

#2443

Change Checklist

  • Requires a change to the documentation
  • Documentation has been updated
  • Tests to cover my changes, have been added
  • All new and existing tests passed.
  • PowerShell v2 compatibility checked.

@vexx32 vexx32 requested review from gep13 and AdmiringWorm March 14, 2022 17:43
Copy link
Member

@AdmiringWorm AdmiringWorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me, however as this was added in v1.0.0 and targeting #2443, the commit and PR fixing the grammar/spelling mistakes should probably target the same issue.

@vexx32
Copy link
Member Author

vexx32 commented Mar 14, 2022

Good idea, I'll update the commit.

@vexx32 vexx32 changed the title (doc) Fix misspellings for profile text (#2443) Fix misspellings for profile text Mar 14, 2022
Copy link
Member

@gep13 gep13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gep13 gep13 merged commit 1a969c2 into chocolatey:develop Mar 15, 2022
@gep13
Copy link
Member

gep13 commented Mar 15, 2022

@vexx32 thank you for noticing and for getting this fixed up!

@vexx32 vexx32 deleted the grammar-fix branch March 15, 2022 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants