(#2602) Add 1.0.0 of shimgen and update shims #2653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Version 1.0.0 of shimgen has been brought into this repository, and the various shims have been updated to use the new standard, including asserted Copyright attributes, etc. The updated .ignore files is assumed to be an issue with either line endings, or encoding, but aren't believed to cause any problems.
|
@AdmiringWorm this is now ready for review |
AdmiringWorm
approved these changes
Mar 14, 2022
|
@gep13 Thank you for getting this added/updated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
Version 1.0.0 of shimgen has been brought into this repository, and the
various shims have been updated to use the new standard, including
asserted Copyright attributes, etc.
The updated .ignore files is assumed to be an issue with either line
endings, or encoding, but aren't believed to cause any problems.
Motivation and Context
A number of small changes have been made in shimgen, and we need
to bring the resulting shimgen.exe into this repository, so it will be used
going forward.
Testing
Generated shims have been tested to ensure that the corresponding action is
carried out, i.e. running
clistresults inchoco listbeing run.Change Types Made
Related Issue
#2602
Change Checklist