Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(maint) Update deprecation notice for config settings #2651

Merged
merged 1 commit into from
Mar 14, 2022

Conversation

AdmiringWorm
Copy link
Member

This pull request updates the deprecation notice mentioned for
obsolete settings values which had initially been slated to
be removed in Chocolatey CLI v1.0.0. However, these are
required by CCM 0.7.0 and needs to be available until we
stop supporting this version.

As such, the deprecation notice is updated to reflect the
status, and the possibility of it being removed in v2.

@AdmiringWorm AdmiringWorm self-assigned this Mar 14, 2022
@AdmiringWorm AdmiringWorm requested a review from gep13 March 14, 2022 09:18
This commit updates the deprecation notice mentioned for
obsolete settings values which had initially been slated to
be removed in Chocolatey CLI v1.0.0. However, these are
required by CCM 0.7.0 and needs to be available until we
stop supporting this version.

As such, the deprecation notice is updated to reflect the
status, and the possibility of it being removed in v2.
@gep13 gep13 force-pushed the config-deprecation-notice branch from fa69684 to 17d2a75 Compare March 14, 2022 10:51
Copy link
Member

@gep13 gep13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gep13
Copy link
Member

gep13 commented Mar 14, 2022

@AdmiringWorm thanks for getting this updated. Will merge this in once the PR's are complete...

@gep13 gep13 merged commit 66281ed into chocolatey:develop Mar 14, 2022
@AdmiringWorm AdmiringWorm deleted the config-deprecation-notice branch March 14, 2022 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants