(Maint) Multiple formatting things #2528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheCakeIsNaOH
force-pushed
the
trailing-whitespace
branch
2 times, most recently
from
363f8b6 to
bfe650d
Compare
TheCakeIsNaOH
force-pushed
the
trailing-whitespace
branch
from
bfe650d to
29ea79d
Compare
This makes the line endings CRLF for three files that had inconsistent line endings.
This adds a trailing new line to files that did not have one. Most of the .cs files had a trailing new line, this makes it consistent across all of the .cs files.
This adds BOMs to .cs files that did not have a BOM. Most of them already had a BOM, this makes it consistent across the codebase.
gep13
force-pushed
the
trailing-whitespace
branch
from
29ea79d to
2456459
Compare
|
@TheCakeIsNaOH this was an amazing PR! Thanks for getting this done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
Four commits, four types of changes across the codebase. The changes only were applied to
.csfiles, there might be files with other extensions I missed..csfiles already had a BOM, now they all do..csfiles already had a trailing newline, now they all do.Motivation and Context
I was tired of fixing trailing whitespace one file at a time, let's fix it all at once. The other things came along for the ride.
Testing
This builds, and the automated tests pass, which helps confirm that I made no code changes, only formatting changes.
While reviewing this, it is probably easiest to review the diff commit by commit.
Change Types Made
Related Issue
N/A, formatting
Change Checklist