(GH-252) PATH exceeding 2048 breaks choco. Use %systemroot% in place of %windir%.

[davehorner]

Issue: #252
%windir% is broken when %path% exceeds 2048 chars, but %systemroot% continues to work.

I found this issue due to cygwin rewriting my PATH to larger than 2048 I believe...
when I echo %windir%, it just prints %windir%.
when I echo %systemroot%, it prints C:\Windows.

I found this from the superuser ticket.
http://superuser.com/questions/719459/strange-path-issue-in-windows-7-goes-null-after-being-set
http://allgeekallthetime.blogspot.com/2012/01/path-over-2048-chars-kills-windir.html

The user experiences something like this:
XXX not upgraded. An error occurred during installation: Unable to find suitable location for PowerShell. Searched the following locations: '%windir%\SysNative\WindowsPowerShell\v1.0\powershell.exe; %windir%\System32\WindowsPowerShell\v1.0\powershell.exe; powershell.exe'

Which is a little confusing, because running powershell.exe works fine. I leave it to the merger to decide if %systemroot% should replace the %windir%, the fix supplied simply adds %systemroot% in addition to %windir%...this works fine too.

Thanks for choco.
--dave

[ferventcoder]

@davehorner have you had an opportunity to read over CONTRIBUTING.md?

[ferventcoder]

I need you to fixup your commit message and sign the CLA. Thanks in advance.

[ferventcoder]

The title is a start. The actual commit will need to be amended to be reworded and then a push back to the branch with --force will get the adjustments up here.

[ferventcoder]

@davehorner have you had a chance to review and respond to my feedback yet?

[davehorner]

working with legal to try and get permission to sign the CLA. Hopefully I will know soon. Sorry and thanks.

[ferventcoder]

@davehorner no worries, thanks for letting me know!

[ferventcoder]

Ping @davehorner

[davehorner]

Sadly I have not received permission to sign the CLA from the legal dept. at my place of employment. I think we may have to forgo my contribution/patch if CLA requirements are truly required. The change is pretty small and easy to recreate. My apologies I could not follow typical project contribution requirements. Thanks for following back, and thanks for the wonderful tool.

--dave

[ferventcoder]

No worries, thanks for following up.