Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(#2465) Fix numerous spelling mistakes #2466

Merged
merged 1 commit into from
Jun 25, 2022
Merged

Conversation

jsoref
Copy link
Contributor

@jsoref jsoref commented Nov 23, 2021

closes #2465
I'm skipping the commit message format for the time being. I'll adjust once the project indicates which changes it's interested in.

CONTRIBUTING.md Outdated Show resolved Hide resolved
GenerateDocs.ps1 Show resolved Hide resolved
GenerateDocs.ps1 Show resolved Hide resolved
docker/Install-ChocolateyInContainer.ps1 Show resolved Hide resolved
docker/Install-ChocolateyInContainer.ps1 Show resolved Hide resolved
src/chocolatey.sln.DotSettings Outdated Show resolved Hide resolved
Copy link
Member

@gep13 gep13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some things that I think would need to be addressed before being able to move forward with this...

docker/Install-ChocolateyInContainer.ps1 Show resolved Hide resolved
lib/NAnt/NAnt.exe.config Outdated Show resolved Hide resolved
lib/ReportGenerator/Readme.txt Outdated Show resolved Hide resolved
nuget/chocolatey/tools/chocolateysetup.psm1 Outdated Show resolved Hide resolved
src/chocolatey.sln.DotSettings Outdated Show resolved Hide resolved
@gep13
Copy link
Member

gep13 commented Nov 23, 2021

@jsoref oh wow! That is a lot of spelling mistakes! A lot of these changes I think we could move forward with, but there are some that I think we would need to back out, and exclude from any future scans.

Copy link
Contributor Author

@jsoref jsoref left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, if you're ready for me to fix up the commit message to style, please let me know how you'd like it done, should it be a single commit, or should I just prefix each commit message with the issue per the style?

(#2465) (maint) Fix typo: ...

I could try to explain the individual impacts, but I'm not sure how valuable that would be.

nuget/chocolatey/tools/chocolateysetup.psm1 Outdated Show resolved Hide resolved
@jsoref jsoref requested a review from gep13 November 24, 2021 04:24
@pauby
Copy link
Member

pauby commented Feb 25, 2022

@jsoref We've not forgotten about this as it's something we want to bring into our build process.

This was done using a GitHub Action which you can find details about
here: https://github.com/marketplace/actions/check-spelling

This may be something that we want to add into the group of GitHub
Actions that we have, but that is something for a different day. For
now, the fixing of the spelling mistakes is enough.

Signed-off-by: Josh Soref <[email protected]>
@coveralls
Copy link

Coverage Status

Coverage remained the same at 28.527% when pulling 372ffa1 on jsoref:spelling into 89dc404 on chocolatey:develop.

Copy link
Member

@gep13 gep13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gep13 gep13 changed the title Spelling (#2465) Fix numerous spelling mistakes Jun 25, 2022
@gep13 gep13 merged commit 6f3fc15 into chocolatey:develop Jun 25, 2022
@gep13
Copy link
Member

gep13 commented Jun 25, 2022

@jsoref this was an AMAZING PR! Thank you very much for doing this, and fixing the spelling mistakes, many of which have been there for a LONG time!

@jsoref jsoref deleted the spelling branch June 26, 2022 02:14
@ferventcoder
Copy link
Member

I agree with @gep13 - this is great, thanks for catching all of these!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Minor spelling errors in chocolatey/choco
5 participants