-
Notifications
You must be signed in to change notification settings - Fork 905
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(#2465) Fix numerous spelling mistakes #2466
Conversation
src/chocolatey.resources/helpers/functions/UnInstall-ChocolateyZipPackage.ps1
Show resolved
Hide resolved
src/chocolatey.tests.integration/infrastructure/cryptography/CryptoHashProviderSpecs.cs
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some things that I think would need to be addressed before being able to move forward with this...
src/chocolatey.tests.integration/infrastructure/cryptography/CryptoHashProviderSpecs.cs
Show resolved
Hide resolved
@jsoref oh wow! That is a lot of spelling mistakes! A lot of these changes I think we could move forward with, but there are some that I think we would need to back out, and exclude from any future scans. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, if you're ready for me to fix up the commit message to style, please let me know how you'd like it done, should it be a single commit, or should I just prefix each commit message with the issue per the style?
(#2465) (maint) Fix typo: ...
I could try to explain the individual impacts, but I'm not sure how valuable that would be.
@jsoref We've not forgotten about this as it's something we want to bring into our build process. |
This was done using a GitHub Action which you can find details about here: https://github.com/marketplace/actions/check-spelling This may be something that we want to add into the group of GitHub Actions that we have, but that is something for a different day. For now, the fixing of the spelling mistakes is enough. Signed-off-by: Josh Soref <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@jsoref this was an AMAZING PR! Thank you very much for doing this, and fixing the spelling mistakes, many of which have been there for a LONG time! |
I agree with @gep13 - this is great, thanks for catching all of these!! |
closes #2465
I'm skipping the commit message format for the time being. I'll adjust once the project indicates which changes it's interested in.