(#2382) Reference new NuGet.Core assembly in chocolatey.console #2405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sole In commit 545ca6c, the chocolatey.console cs project was not updated, unlike the other projects. This updates that project in line with the others.
TheCakeIsNaOH
force-pushed
the
nuget-reference
branch
from
e9c541c to
3d724c4
Compare
TheCakeIsNaOH
changed the title
|
@TheCakeIsNaOH thank you VERY much for looking into this. This was on my immediate todo list for this morning, as I never got a chance to look at it yesterday since I had back to back meetings all afternoon. This is indeed very strange as the build worked fine for me locally as well, and all the GitHub Action builds worked. Don't think we need to dig too far into what the difference here is, just happy that you were able to resolve it. |
|
You are very welcome. My visual studio debug build was working, but not I find ripgrep very helpful in cases like this, it's a couple of seconds to search all the files in the repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In commit 545ca6c, the chocolatey.console cs project was not updated,
unlike the other projects. This updates that project in line with the
others.
This should fix the AppVeyor build. I'm not sure why the GitHub actions build was working, but not the AppVeyor build.
Relates to #2382