(#2076) Pack always truncate stream #2276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheCakeIsNaOH
force-pushed
the
mono-truncate
branch
from
f276f08 to
83e14ac
Compare
gep13
force-pushed
the
mono-truncate
branch
from
83e14ac to
f5fc7ba
Compare
Mono does not truncate streams in System.IO.Packaging.Package.Open when using FileMode.Create, while .Net does. mono/mono#21055 This always truncates the stream at the start.
gep13
force-pushed
the
mono-truncate
branch
from
f5fc7ba to
59efd51
Compare
|
@TheCakeIsNaOH thanks for getting this fixed up! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mono does not truncate streams in System.IO.Packaging.Package.Open
when using FileMode.Create, while .Net does. mono/mono#21055
This always truncates the stream at the start.
Fixes #2076