(#2238) Mono build don't hardcode xbuild path #2239
Conversation
|
@ferventcoder would you be in a position to provide some guidance here? The idea behind this is that we would like to build Chocolatey on GitHub Actions, running on Windows, Mac and Linux, and there is an issue when trying this due to the location of the xbuild application on some runners. I know that directly editing the UppercuT files is not recommended, so I am curious as to what the best course of action is here. |
Removes basedir from Mono build on non-windows platforms. This lets xbuild be located at other locations, as long at it's on the path
|
@TheCakeIsNaOH thanks for investigating this, and for finding a solution. Will get this merged once the CI builds complete. |
|
There is an open GitHub Actions incident which I believe is why the Windows build isn't working correctly: https://www.githubstatus.com/incidents/cj7gzzj30411 Since this change only impacts the Posix build, which has passed, I am going to go ahead and merge this in. |
|
@TheCakeIsNaOH thanks again for getting this fixed up! |
Now that this PR has been merged in: #2239 It should be possible to add Mac build into the main GitHub Action workflow. Co-authored-by: TheCakeIsNaOH <[email protected]>
Removes basedir from Mono build on non-windows platforms.
This lets xbuild be located at other locations, as long at it's on the path
Fixes: #2238
I'm not %100 sure that this is the best solution, but it seems to work everwhere I have tested it.
Ubuntu, Debian, Docker, and MacOS (in Github actions) all build.
I'm not super familiar with uppercut, so if there is a better way to do this, I'm all ears.