(#2227) Bring Ubuntu to 18.04 in Travis #2228
Conversation
gliptak
changed the title
|
@gep13 please review |
|
@TheCakeIsNaOH as someone who is more familiar with building the mono compatible version of Chocolatey, would you mind doing a review of this PR? Thanks! |
|
So this fixes the SSL issue by bumping the OS version from 16.04 to 18.04, and pulling the newer root certificates from the OS (ca-certificates), which mono can then use. My inclination would be instead to bump the mono version, which would then bring in the newer root certificates directly in mono. This would help avoid getting stuck on an old mono version and causing issues like #1020 I tried this with #2234, and travis is working fine with the newer mono version there. |
|
@TheCakeIsNaOH this seems like a sensible approach to me. @gliptak what are your thoughts here? If you wanted to update this PR to use this suggestion, we can look to get it merged in. |
|
I certainly can add Mono bump to |
When building the chocolatey code base on Travis, there is a failure when trying to restore nuget packages. This is due to the fact that an older version of Mono doesn't contain the newer root certificates necessary to ensure a valid TLS handshake. Using a newer version of Mono ensures that these are in place. In addition, updating to the latest Ubuntu (bionic).
|
@gliptak thank you very much for taking the time to get this fixed up, appreciate it! And thanks to @TheCakeIsNaOH for the assist! |
Bring Mono version in line with version in CI configuration, which was updated by chocolatey#2228
Bring Mono version in line with version in CI configuration, which was updated by chocolatey#2228
Fixes #2227