(GH-2044) Fix for changing $env:Temp #2154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@vexx32 any chance you can take a look at this one, thanks? |
vexx32
requested changes
Apr 19, 2021
| Set-Item "Env:$($_)" -Value (Get-EnvironmentVariable -Scope $scope -Name $_) | ||
| #ordering is important here, $user should override $machine... | ||
| $Scopes = 'Process', 'Machine' | ||
| if (($userName -ne 'SYSTEM') -and ($userName -ne "$($env:COMPUTERNAME)`$")) { |
There was a problem hiding this comment.
This might be clearer to write as:
Suggested change
| if (($userName -ne 'SYSTEM') -and ($userName -ne "$($env:COMPUTERNAME)`$")) { | |
| if ($userName -notin 'SYSTEM', "${env:COMPUTERNAME}`$") { | |
| # but only if not running as the SYSTEM/machine in which case user can be ignored. | ||
| $Scopes += 'User' | ||
| } | ||
| foreach ($Scope in $Scopes) { |
There was a problem hiding this comment.
I generally recommend avoiding plural variables be used alongside singular counterparts; it's very easy to mess things up with a single-character typo and not notice that the logic is totally broken until later. Maybe use $ScopeList instead for the latter variable?
| foreach ($Scope in $Scopes) { | ||
| Get-EnvironmentVariableNames -Scope $Scope | | ||
| ForEach-Object { | ||
| Set-Item "Env:$($_)" -Value (Get-EnvironmentVariable -Scope $Scope -Name $_) |
There was a problem hiding this comment.
Unnecessary subexpression wrapper in this string
Suggested change
| Set-Item "Env:$($_)" -Value (Get-EnvironmentVariable -Scope $Scope -Name $_) | |
| Set-Item "Env:$_" -Value (Get-EnvironmentVariable -Scope $Scope -Name $_) |
|
I agree with all the comments by @vexx32 and I think I've made the adjustments so they roll into this PR. (I'm not very good with GitHub and how the change management flow works.) |
vexx32
approved these changes
Apr 19, 2021
Running as `SYSTEM`, the `$env:Temp` variable is normally *C:\Windows\Temp*. If the **first** package to ever use `Update-SessionEnvironment.ps1` happens to be running as `SYSTEM`, the location of `$env:Temp` changes to *C:\Windows\system32\config\systemprofile\AppData\Local\Temp* for the duration of the session. This change to `$env:Temp` does not occur in subsequent calls to `Update-SessionEnvironment.ps1`. It is unknown why this change occurs at all and likewise is unknown why it occurs for only the first time. The `Update-SessionEnvironment.ps1` normally gives priority to user-scope environment variables over machine-scope environment variables. Changes in this commit eliminates the gathering of the `User` scope environment variables when running as the `SYSTEM` account on the belief that reason to be operating under the `SYSTEM` account is to do machine-wide activities, and there is no reason to see `SYSTEM` as a "user". On a clean system, the only User-scope environment variables under `SYSTEM` are *path*, *temp*, and *tmp* which are already defined under the Machine-scope, and in general, there shouldn't be any new User-scope variables for the SYSTEM account because it's not a "normal" account. Basically, there should be little reason to expect this change to break anything.
" is not required here, as we are not including any variables.
|
@teknowledgist thank you very much for taking the time to submit this PR, we really appreciate it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(GH-2044) This fixes a problem when a package is installed under the System credentials (typically how centralized management software -- e.g. SCCM -- operate):
Running as
SYSTEM, the$env:Tempvariable is normally C:\Windows\Temp. If the first package to ever useUpdate-SessionEnvironment.ps1happens to be running asSYSTEM, the location of$env:Tempchanges to C:\Windows\system32\config\systemprofile\AppData\Local\Temp for the duration of the session. This change to$env:Tempdoes not occur in subsequent calls toUpdate-SessionEnvironment.ps1. It is unknown why this change occurs at all and likewise is unknown why it occurs for only the first time.The
Update-SessionEnvironment.ps1normally gives priority to user-scope environment variables over machine-scope environment variables. Changes in this commit eliminates the gathering of theUserscope environment variables when running as theSYSTEMaccount on the belief that reason to be operating under theSYSTEMaccount is to do machine-wide activities, and there is no reason to seeSYSTEMas a "user". On a clean system, the only User-scope environment variables underSYSTEMare path, temp, and tmp which are already defined under the Machine-scope, and in general, there shouldn't be any new User-scope variables for the SYSTEM account because it's not a "normal" account. Basically, there should be little reason to expect this change to break anything.Fixes #2044