(GH-1889) Fixes Equals implementation of ConfigFileApiKeySettings #1890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ferventcoder
reviewed
Aug 2, 2019
| @@ -43,7 +43,7 @@ public override bool Equals(object obj) | |||
| var item = (ConfigFileApiKeySetting) obj; | |||
|
|
|||
| return (Source == item.Source) | |||
| && (Key == item.Source); | |||
| && (Key == item.Key); | |||
There was a problem hiding this comment.
Good catch! This came in as a PR and it appears this was missed on the review!
ferventcoder
requested changes
Aug 2, 2019
skel35
force-pushed
the
f/GH-1889-Fix-ApiKey-Remove
branch
from
c6d8ded to
5dccfd7
Compare
|
Updated the commit message |
|
I would see the git commit summary of this fix be |
skel35
force-pushed
the
f/GH-1889-Fix-ApiKey-Remove
branch
from
5dccfd7 to
731296f
Compare
ferventcoder
approved these changes
Jun 3, 2020
|
This is ready to be pulled into stable! |
|
Thanks for getting that updated. |
|
|
|
@ferventcoder why is this still not merged? everything seems to be in place? |
`remove_api_key` was previously not working properly. The API key string did not get removed from the config file due to incorrect implementation of Equals method in ConfigFileApiKeySettings class. Current commit fixes this issue.
gep13
force-pushed
the
f/GH-1889-Fix-ApiKey-Remove
branch
from
731296f to
e89ee92
Compare
|
@skel35 thanks again for taking the time to address this issue! Once the CI builds are completed, I will get this merged in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Equalsimplementation ofConfigFileApiKeySettings.This is the line which failed due to
Equalsnot working correctly:choco/src/chocolatey/infrastructure.app/services/ChocolateyConfigSettingsService.cs
Line 338 in 98f8053
Closes #1889.