Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(maint) Replace RawGit with raw.githack.com CDN #1884

Merged
merged 1 commit into from
Apr 18, 2021

Conversation

PeterDaveHello
Copy link
Contributor

RawGit is shutting down since October 2018, the content already been
serving will continue to be served until at least October of 2019, but
new content will not be served, the homepage https://rawgit.com/ says:

If you're currently using RawGit,
please stop using it as soon as you can.

raw.githack.com is another popular CDN service for repositories on
GitHub, and more, also including GitLab and Bitbucket, which provides
package maintainers more flexibility.

@gep13 gep13 changed the title (maint) Repalce RawGit with raw.githack.com CDN (maint) Replace RawGit with raw.githack.com CDN Jul 20, 2019
@@ -59,7 +59,7 @@ public class NuspecTemplate
<authors>__REPLACE_AUTHORS_OF_SOFTWARE_COMMA_SEPARATED__</authors>
<!-- projectUrl is required for the community feed -->
<projectUrl>https://_Software_Location_REMOVE_OR_FILL_OUT_</projectUrl>
<!--<iconUrl>http://cdn.rawgit.com/[[MaintainerRepo]]/master/icons/[[PackageNameLower]].png</iconUrl>-->
<!--<iconUrl>http://rawcdn.githack.com/[[MaintainerRepo]]/master/icons/[[PackageNameLower]].png</iconUrl>-->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should point to the Icon Guidelines here rather than specifying a specific service.

/cc @gep13 @ferventcoder

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree. @PeterDaveHello if you can point to this, that would allow us to pull this in.

Copy link
Member

@ferventcoder ferventcoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the one small thing - this looks great otherwise!

@PeterDaveHello
Copy link
Contributor Author

I think it's in the guidelines already, isn't it? Just upload the example here to make it valid and as an useful reminder in the template, what do you think?

@bcurran3
Copy link

There are other CDNs that probably should be mentioned as well.
REF: chocolatey/choco-wiki#106

@CLAassistant
Copy link

CLAassistant commented Jun 8, 2020

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
10 out of 12 committers have signed the CLA.

✅ gliptak
✅ gep13
✅ GankousKhan
✅ DdOtzen
✅ peteraritchie
✅ flcdrg
✅ jetersen
✅ skel35
✅ TheCakeIsNaOH
✅ FLeXyo
❌ Mauville
❌ PeterDaveHello
You have signed the CLA already but the status is still pending? Let us recheck it.

RawGit is shutting down since October 2018, the content already been
serving will continue to be served until at least October of 2019, but
new content will not be served, the homepage https://rawgit.com/ says:

> If you're currently using RawGit,
> please stop using it as soon as you can.

raw.githack.com is another popular CDN service for repositories on
GitHub, and more, also including GitLab and Bitbucket, which provides
package maintainers more flexibility.
@gep13 gep13 changed the base branch from master to stable April 18, 2021 18:39
Copy link
Member

@gep13 gep13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gep13
Copy link
Member

gep13 commented Apr 18, 2021

@PeterDaveHello Thank you for taking the time to get this updated, really appreciate it! Since this is a simple documentation change, signing of the CLA is not required, so I am going to move forward to get this merged in.

@gep13 gep13 merged commit 2b00069 into chocolatey:stable Apr 18, 2021
@gep13
Copy link
Member

gep13 commented Apr 18, 2021

@PeterDaveHello thanks again for your help here!

@PeterDaveHello
Copy link
Contributor Author

Thanks @gep13 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants