-
Notifications
You must be signed in to change notification settings - Fork 906
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(maint) Replace RawGit with raw.githack.com CDN #1884
Conversation
@@ -59,7 +59,7 @@ public class NuspecTemplate | |||
<authors>__REPLACE_AUTHORS_OF_SOFTWARE_COMMA_SEPARATED__</authors> | |||
<!-- projectUrl is required for the community feed --> | |||
<projectUrl>https://_Software_Location_REMOVE_OR_FILL_OUT_</projectUrl> | |||
<!--<iconUrl>http://cdn.rawgit.com/[[MaintainerRepo]]/master/icons/[[PackageNameLower]].png</iconUrl>--> | |||
<!--<iconUrl>http://rawcdn.githack.com/[[MaintainerRepo]]/master/icons/[[PackageNameLower]].png</iconUrl>--> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should point to the Icon Guidelines here rather than specifying a specific service.
/cc @gep13 @ferventcoder
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree. @PeterDaveHello if you can point to this, that would allow us to pull this in.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just the one small thing - this looks great otherwise!
I think it's in the guidelines already, isn't it? Just upload the example here to make it valid and as an useful reminder in the template, what do you think? |
There are other CDNs that probably should be mentioned as well. |
|
RawGit is shutting down since October 2018, the content already been serving will continue to be served until at least October of 2019, but new content will not be served, the homepage https://rawgit.com/ says: > If you're currently using RawGit, > please stop using it as soon as you can. raw.githack.com is another popular CDN service for repositories on GitHub, and more, also including GitLab and Bitbucket, which provides package maintainers more flexibility.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@PeterDaveHello Thank you for taking the time to get this updated, really appreciate it! Since this is a simple documentation change, signing of the CLA is not required, so I am going to move forward to get this merged in. |
@PeterDaveHello thanks again for your help here! |
Thanks @gep13 ! |
RawGit is shutting down since October 2018, the content already been
serving will continue to be served until at least October of 2019, but
new content will not be served, the homepage https://rawgit.com/ says:
raw.githack.com is another popular CDN service for repositories on
GitHub, and more, also including GitLab and Bitbucket, which provides
package maintainers more flexibility.