(maint) Improve log message #1852
Conversation
| @@ -464,7 +464,7 @@ public void install_noop(ChocolateyConfiguration config, Action<PackageResult> c | |||
|
|
|||
| if (installedPackage != null && version != null && version < installedPackage.Version && !config.AllowMultipleVersions && !config.AllowDowngrade) | |||
| { | |||
| string logMessage = "A newer version of {0} (v{1}) is already installed.{2} Use --allow-downgrade or --force to attempt to install older versions, or use side by side to allow multiple versions.".format_with(installedPackage.Id, installedPackage.Version, Environment.NewLine); | |||
| string logMessage = "A newer version of {0} (v{1}) is already installed.{2} Use --allow-downgrade or --force to attempt to install older versions, or use --sidebyside to allow multiple versions.".format_with(installedPackage.Id, installedPackage.Version, Environment.NewLine); | |||
There was a problem hiding this comment.
While this looks great, can we get it as --side-by-side or --allow-multiple-versions?
There was a problem hiding this comment.
I'm not following.
As in:
install older versions, or use --side-by-side to --allow-multiple-versions.".
Because I'm not sure if that last one is a switch
There was a problem hiding this comment.
@Mauville he is talking about changing --sidebyside to either --side-by-side or to --allow-multiple-versions.
For instance:
or use --side-by-side to allow multiple versions
or
or use --allow-multiple-versions to allow multiple versions
There was a problem hiding this comment.
Ok. I feel like --side-by-side would be a better alternative in this case because syntactically speaking, it makes more sense to pass a flag like
choco install anki --side-by-side
than
choco install anki --allow-multiple-versions
There was a problem hiding this comment.
Hi @Mauville! Thanks for providing that to improve our messaging. I have one small request on the way that is formatted. If you need any help on that, let us know. If you want us to go ahead and fix it for you as we pull it in, we can do that as well.
Thanks. I would gladly appreciate it. |
|
|
The log message when trying to downgrade a program shows a variety of switches, --force, --allow-downgrade One of these is formatted as prose, side by side Changed to reflect proper switch syntax.
|
@Mauville thank you very much for taking the time to raise this PR. I have taken the liberty of making the suggested changes, and I have pushed these changes to your branch. Since this is a minor documentation change, and not changing any of the functional code, signing of the CLA is not required. Once the CI builds are completed, I will get this change merged in. |
|
@Mauville thanks again for your contribution here! |
The log message when trying to downgrade a program
shows a variety of switches, --force, --allow-downgrade
One of these is formatted as prose, side by side
Changed to reflect proper switch syntax.