(GH-1689) Remove packaging script before upgrade #1751
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Of course there would be an integration test that verifies what is removed and what should not be, so it will need adjusted to account for this. I can manage grabbing that if I finish it tonight. Otherwise you may want to review the failed AppVeyor log and take a look at the test to update it for this behavior. |
It is possible, due to the way that Package Reducer works, that there are extra files left in the package directory when doing an upgrade of a package. This can cause a package upgrade to fail. Prior to performing the upgrade, delete all packaging scripts (chocolateyInstall, chocolateyUninstall, and chocolateyBeforeModify) from the package folder, these will then be replaced during the upgrade, if they are still required..
|
@ferventcoder I went down the route of changing the tests, but then I realised that the function that I added wasn't constrained to only happen during an upgrade, which I believe it should be. I have added this in, and the tests that were failing are now all passing again. Let me know if you want additional changes. |
|
This was rebased against stable and merged in at cb2799b. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is possible, due to the way that Package Reducer works, that there
are extra files left in the package directory when doing an upgrade
of a package. This can cause a package upgrade to fail. Prior to
performing the upgrade, delete all packaging scripts (chocolateyInstall,
chocolateyUninstall, and chocolateyBeforeModify) from the package
folder, these will then be replaced during the upgrade, if they are
still required.
Closes #1689