Updates to Install-ChocolateyZipPackage.ps1 #1732
Conversation
There was a problem hiding this comment.
@it-praktyk Great start, just have a couple fix ups requested. Thanks!
| @@ -196,14 +199,14 @@ param( | |||
|
|
|||
| $chocTempDir = $env:TEMP | |||
| $tempDir = Join-Path $chocTempDir "$($env:chocolateyPackageName)" | |||
| if ($env:chocolateyPackageVersion -ne $null) { $tempDir = Join-Path $tempDir "$($env:chocolateyPackageVersion)"; } | |||
| if ($null -ne $env:chocolateyPackageVersion) { $tempDir = Join-Path $tempDir "$($env:chocolateyPackageVersion)"; } | |||
There was a problem hiding this comment.
@it-praktyk curious how this is a code smell. Also, the commit message is going to need quite a bit more to explain the change, explain the reasoning, etc. Feel free to start the message with a good summary, but then dive into all of the why in the git commit message.
There was a problem hiding this comment.
OK, you are right. I've reworded the commit message.
| @@ -71,6 +71,9 @@ likely your script folder. If unzipping to your package folder, the path | |||
| will be like | |||
| `"$(Split-Path -Parent $MyInvocation.MyCommand.Definition)\\file.exe"` | |||
|
|
|||
| .PARAMETER SpecificFolder | |||
| OPTIONAL - This is a specific directory within zip file to extract. | |||
|
|
|||
There was a problem hiding this comment.
Thanks for putting that in!
There was a problem hiding this comment.
We may want to explain what version this is first available in or when it was fixed to work appropriately (the released version of choco where this was known to work) - it worked in earlier code, stopped working for awhile, and then started working again more recently when something was fixed.
There was a problem hiding this comment.
I see you are simply bringing over
to here. That's fine. We can leave out the details if you want.There was a problem hiding this comment.
This was the specific commit that fixed this issue - 3b13869
it-praktyk
force-pushed
the
Update_Install-ChocolateyZipPackage-1
branch
from
fc70d5e to
7125a9d
Compare
it-praktyk
force-pushed
the
Update_Install-ChocolateyZipPackage-1
branch
from
7125a9d to
48cc838
Compare
it-praktyk
changed the title
|
|
No description provided.