Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(GH-1415) Correct issue with remove zip file contents #1509

Merged
merged 1 commit into from
Feb 26, 2018
Merged

(GH-1415) Correct issue with remove zip file contents #1509

merged 1 commit into from
Feb 26, 2018

Conversation

gep13
Copy link
Member

@gep13 gep13 commented Feb 23, 2018

Fixes #1415

@gep13
(chocolateyGH-1415) Added additional check for zip content file
67d4ad1 
- Check for the existence of the Install.txt file
- If that doesn't exist, fall back to the old filename
- Delete all files in content file as before
@gep13 gep13 requested a review from ferventcoder February 23, 2018 11:51
ferventcoder
ferventcoder approved these changes Feb 24, 2018
View reviewed changes
Copy link
Member

@ferventcoder ferventcoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 looks good. Will pull it in soon!

@ferventcoder ferventcoder merged commit 96522e4 into chocolatey:stable Feb 26, 2018
@gep13 gep13 deleted the issue-1415 branch February 27, 2018 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ferventcoder ferventcoder ferventcoder approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gep13 @ferventcoder