global mutex for XML serialization & deserialization #1264
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a single global mutex (process-wide) on serialization and deserialization of the xml-configuration file ensures the file stays consistent
corrected bracketing, visibility modifiers and namespace
|
@mwallner are you able to sign the CLA agreement? |
|
Looks like that is good to go now. |
|
You got some where whitespace happening in this PR. |
|
Thanks for the contribution! This was fixed up, rebased and merged into stable at 5469ccd. Got a few other commits in there as most of them tended to be interrelated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this should fix GH-1258