(GH-1106) Hide sensitive data in choco apikey call output #1122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulhunttech
changed the title
paulhunttech
changed the title
|
Looks good, can you squash this down to one commit? |
ferventcoder
changed the title
ferventcoder
requested changes
Jan 3, 2017
paulhunttech
force-pushed
the
woodburysoft/HideCredentialsInChocoApikeyCallOutput
branch
from
611e038 to
7ff013f
Compare
Previously the 'choco apikey' command wrote the API key for a source to the output in plain text which is a potential security issue. Update the generated output to "(Authenticated)" if the API key is not null or whitespace. Replaced credentials from apikey output and replaced with "(Authenticated)".
|
Had some fun & games squashing as I'd never done it before but I believe it's right now. |
|
Merged into stable at fe55f47. Thanks for your contribution! This will be in the 0.10.4 release! |
ferventcoder
approved these changes
Mar 22, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1106
Replaced plain text api key output with "(Authenticated)" where the api key is not null or whitespace.