-
Notifications
You must be signed in to change notification settings - Fork 904
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(GH-676) SpecificFolder feature fixed #1023
Conversation
Tested with Install-ChocolateyZipPackage $packageName $url $toolsDir $url64 -checksum $checksum -checksumType $checksumType -checksum64 $checksum64 -checksumType64 $checksumType64 -SpecificFolder 'x64' against http://www.zezula.net/download/bellavista_en.zip
+1 on this. I'm running into this myself, I have a dependent zip which unfortunately has the dependent files deeper than the archive root. |
When this fix is expected to be released? |
|
||
Write-FunctionCallLogMessage -Invocation $MyInvocation -Parameters $PSBoundParameters | ||
|
||
if ($packageName) { | ||
$packagelibPath = $env:ChocolateyPackageFolder | ||
if (!(Test-Path -path $packagelibPath)) { | ||
New-Item $packagelibPath -type directory | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure why this was removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Granted, that folder should exist.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rob - It has been too long - I can't remember. I am pretty sure that I wouldn't have removed it only because I noticed the folder was already there because I wouldn't know if under other conditions it might not exist by this point.
But it does seem like seem like an out of place removal.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No worries.
Some small fixups and merged into stable at 845a604 |
This will be released with 0.10.4. |
And when 0.10.4 is planned to he out? |
Hi @bazzilic - estimation is hard, so I'm going to give you the tools to learn how to better determine when any next release of Chocolatey is coming out. Head over to issues, click on milestones and select the release you care about. HTH |
The best answer I have is this is number 1 priority right now, so as soon as all the issues are complete. We hoped for end of February, but that didn't occur, so really trying to get it complete in March. |
Fixed and tested. Preserved full path in zip since this is the default behavior of pulling a specific path out of an archive.
Closes #676