Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Note that chocolateyUninstall.ps1 may no longer required in template #982

Closed
Daniel15 opened this issue Sep 26, 2016 · 1 comment
Closed

Note that chocolateyUninstall.ps1 may no longer required in template #982

Daniel15 opened this issue Sep 26, 2016 · 1 comment
Assignees
@ferventcoder
Labels
5 - Released Documentation Improvement Priority_LOW
Milestone
0.10.2

Comments

@Daniel15
Copy link

Daniel15 commented Sep 26, 2016 •
edited
Loading

After running choco new, it creates a fairly large chocolateyUninstall.ps1. However, reading https://github.com/chocolatey/choco/wiki/HelpersUninstallChocolateyPackage, it seems like this is no longer required for MSI installers. Maybe there should be a comment at the top of the file explaining that?
@gep13 gep13 changed the title Default chocolateyUnnstall.ps1 no longer required? Default chocolateyUninstall.ps1 no longer required? Sep 26, 2016
@ferventcoder
Copy link
Member

Ah, good point - in 80-90% of the cases it is no longer required. In licensed versions there are additional enhancements and Package Synchronizer that bump that up to almost 100%. A comment as to such is a good idea.

@ferventcoder ferventcoder added this to the 0.10.2 milestone Sep 26, 2016
@ferventcoder ferventcoder self-assigned this Sep 26, 2016
@ferventcoder ferventcoder changed the title Default chocolateyUninstall.ps1 no longer required? Note that chocolateyUninstall.ps1 may no longer required in template Sep 27, 2016
ferventcoder added a commit that referenced this issue Sep 30, 2016
@ferventcoder
(GH-982) Note AutoUninstaller in uninstall template
991b521 
Provide guidance at the top of the uninstall template that the
uninstall script may be unnecessary due to AutoUninstaller and licensed
version enhancements.
ferventcoder added a commit that referenced this issue Sep 30, 2016
@ferventcoder
Merge branch 'stable'
2c4dc5b 
* stable:
  (version) 0.10.2
  (doc) update CHANGELOG/nuspec
  (GH-992) allow uninstall scripts for side by side
  (GH-992) search for sidebyside install first
  (GH-992) Uninstall should always work with version
  (maint) RefreshEnv.cmd mentions cmd.exe
  (maint) fix message
  (spec) support no prompting
  (GH-986) Remove extra forward slashes in url
  (GH-573) Explain Failing Uninstall Options
  (GH-985) rollback automatically on user cancel
  (GH-984) Detect licensed options in FOSS
  (GH-983) Do not add unparsed options to package names
  (GH-982) Note AutoUninstaller in uninstall template
  (docs) clean up messaging for logo use policy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ferventcoder ferventcoder

Labels
5 - Released Documentation Improvement Priority_LOW
Projects
None yet
Milestone
0.10.2
Development

No branches or pull requests
3 participants
@ferventcoder @Daniel15 @gep13