Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

choco install relativepath/to/some.nuspec fails #906

Closed
DarwinJS opened this issue Aug 13, 2016 · 2 comments
Closed

choco install relativepath/to/some.nuspec fails #906

DarwinJS opened this issue Aug 13, 2016 · 2 comments
Assignees
@ferventcoder
Labels
5 - Released Bug Up For Grabs
Milestone
0.10.4

Comments

@DarwinJS
Copy link
Contributor

DarwinJS commented Aug 13, 2016 •
edited
Loading

For installs directly against a .nuspec, it appears that the .nupkg is runtime compiled into the working folder, but then when the call to 'install' is passed internally in choco, the source folder is given as the same folder as the .nuspec.

So if do this:
c:\somefolder> cinst -y subfolder\my.nuspec

The .nupkg ends up in "somefolder" but choco errors out that it can't find the package in c:\somefolder\subfolder.

choco version 0.10.0.
@ferventcoder ferventcoder added this to the 0.10.1 milestone Aug 15, 2016
@ferventcoder ferventcoder modified the milestones: 0.10.1, 0.10.2 Sep 7, 2016
@ferventcoder ferventcoder modified the milestones: 0.10.2, 0.10.3 Sep 20, 2016
@ferventcoder ferventcoder modified the milestones: 0.10.3, 0.10.4 Oct 3, 2016
@paulhunttech
Copy link

I'm happy to take a look at this if nobody objects

paulhunttech pushed a commit to paulhunttech/choco that referenced this issue Jan 4, 2017
(chocolateyGH-906) Fix source path used when installing from nuspec f…
b79b5ad 
…ile.

Previously when the install target was a nuspec file and the output
folder was not set to the folder that contained the nuspec file then
the installation failed because the nupkg file could not be found.
Update sets the sources parameter to the output folder during the
packaging of the nuspec file.
@paulhunttech paulhunttech mentioned this issue Mar 22, 2017
Closed
ferventcoder pushed a commit that referenced this issue Mar 22, 2017
@ferventcoder
(GH-906) Fix source path when installing "*.nuspec"
17faf92 
Previously, when the install target was a nuspec file and the output
folder was not set to the folder that contained the nuspec file then
the installation failed because the nupkg file could not be found.
Update sets the sources parameter to the output folder during the
packaging of the nuspec file.
ferventcoder added a commit that referenced this issue Mar 22, 2017
@ferventcoder
Merge branch 'pr1127' into stable
94a448d 
* pr1127:
  (GH-906) Fix source path when installing "*.nuspec"
ferventcoder added a commit that referenced this issue Mar 22, 2017
@ferventcoder
Merge branch 'stable'
3be0f1a 
* stable:
  (GH-906) Fix source path when installing "*.nuspec"
  (GH-523) Install "*.nupkg" - Be explicit about version
@ferventcoder ferventcoder self-assigned this Mar 22, 2017
@ferventcoder
Copy link
Member

Fixed for 0.10.4

@gep13 gep13 removed the 4 - Done label Sep 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ferventcoder ferventcoder

Labels
5 - Released Bug Up For Grabs
Projects
None yet
Milestone
0.10.4
Development

No branches or pull requests
4 participants
@ferventcoder @gep13 @DarwinJS @paulhunttech