Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Option to apply package parameters / install arguments to dependent packages #839

Closed
eirikatdips opened this issue Jun 29, 2016 · 5 comments
Closed

Option to apply package parameters / install arguments to dependent packages #839

eirikatdips opened this issue Jun 29, 2016 · 5 comments
Assignees
@ferventcoder
Labels
5 - Released Customer Improvement
Milestone
0.10.1

Comments

@eirikatdips
Copy link
Contributor

From chocolatey version 9.10, package parameters will not be applied to dependent packages. That makes sense, as it could cause unexpected behavior. However, there are situations where it would be very useful to be able to do that. We have divided our application into multiple packages, which all makes use of the same input parameters. So it would be very useful if we could apply the parameters also to dependent packages. It should be a switch, named something like --applytoallpackages, --applytoall, etc

It should be easy to implement, I think, looking at the code change done for this issue:
0e0ddfa
@ferventcoder
Copy link
Member

This was caused by #733

@ferventcoder ferventcoder added this to the 0.9.10.x milestone Jun 29, 2016
@ferventcoder ferventcoder changed the title Request: switch to apply package parameters to dependant packages Request: switch to apply package parameters to dependent packages Jun 29, 2016
@ferventcoder ferventcoder modified the milestones: 0.10.1, 0.10.x Aug 17, 2016
@ferventcoder
Copy link
Member

I think we will implement this as

  • --apply-package-parameters-to-dependencies
  • --apply-install-arguments-to-dependencies

@ferventcoder ferventcoder self-assigned this Aug 17, 2016
eirikatdips added a commit to eirikatdips/choco that referenced this issue Aug 18, 2016
@eirikatdips
(chocolateyGH-839) Switch to apply package parameters to dependent pa…
a47711e 
…ckages

In version 0.9.9.8 and earlier, package-parameters would also be applied to dependent packages, but in choco 0.9.10 this was changed so that package-parameters would only be applied to the specified package.
Sometimes it will be useful to pass the package parameters further to dependent packages. This can be controlled by using a cmdline switch.
eirikatdips added a commit to eirikatdips/choco that referenced this issue Aug 22, 2016
@eirikatdips
(chocolateyGH-839) Switch to apply package parameters to dependent pa…
6a959bb 
…ckages

In version 0.9.9.12 and earlier, install arguments and package-parameters would also be applied to dependent packages, but in choco 0.9.10 this was changed so that it would only be applied to the specified package.
Sometimes it will be useful to pass the install arguments and package parameters further to dependent packages. This can be controlled by using cmdline switches.
eirikatdips added a commit to eirikatdips/choco that referenced this issue Aug 22, 2016
@eirikatdips
(chocolateyGH-839) Switch to apply package parameters to dependent pa…
2042b15 
…ckages

In version 0.9.9.12 and earlier, install arguments and package-parameters would also be applied to dependent packages, but in choco 0.9.10 this was changed so that it would only be applied to the specified package.
 Sometimes it will be useful to pass install arguments and package parameters further to dependent packages. This can be controlled by using cmdline switches.
eirikatdips added a commit to eirikatdips/choco that referenced this issue Aug 22, 2016
@eirikatdips
(chocolateyGH-839) Switch to apply package parameters to dependent pa…
5d26773 
…ckages

In version 0.9.9.12 and earlier, install arguments and package-parameters would also be applied to dependent packages, but in choco 0.9.10 this was changed so that it would only be applied to the specified package.
Sometimes it will be useful to pass the install arguments and package parameters further to dependent packages. This can be controlled by using cmdline switches.
eirikatdips added a commit to eirikatdips/choco that referenced this issue Aug 22, 2016
@eirikatdips
(chocolateyGH-839) Switch to apply package parameters to dependent pa…
ec7bc88 
…ckages

In version 0.9.9.12 and earlier, install arguments and package-parameters would also be applied to dependent packages, but in choco 0.9.10 this was changed so that it would only be applied to the specified package.
Sometimes it will be useful to pass the install arguments and package parameters further to dependent packages. This can be controlled by using cmdline switches.
eirikatdips added a commit to eirikatdips/choco that referenced this issue Aug 25, 2016
@eirikatdips
(chocolateyGH-839) Switch to apply package parameters to dependent pa…
a30dd76 
…ckages

In version 0.9.9.12 and earlier, install arguments and package-parameters would also be applied to dependent packages, but in choco 0.9.10 this was changed so that it would only be applied to the specified package.
Sometimes it will be useful to pass the install arguments and package parameters further to dependent packages. This can be controlled by using cmdline switches.
ferventcoder pushed a commit that referenced this issue Sep 12, 2016
@eirikatdips @ferventcoder
(GH-839) Switch to apply package parameters to dependent packages
7d485df 
In version 0.9.9.12 and earlier, install arguments and package-parameters would also be applied to dependent packages, but in choco 0.9.10 this was changed so that it would only be applied to the specified package.
Sometimes it will be useful to pass the install arguments and package parameters further to dependent packages. This can be controlled by using cmdline switches.
ferventcoder added a commit that referenced this issue Sep 12, 2016
@ferventcoder
Merge branch 'pr915' into stable
315a882 
* pr915:
  (GH-839) Switch to apply package parameters to dependent packages
ferventcoder added a commit that referenced this issue Sep 12, 2016
@ferventcoder
Merge branch 'stable'
e26c02c 
* stable: (24 commits)
  (GH-839) Switch to apply package parameters to dependent packages
  (maint) formatting methods / parameters in calls
  (GH-958) If SSLv3 in Posh v2 Fails, Use Original
  (GH-746) Use HTTPS if available when HTTP url
  (GH-957) Skip Get-WebFileName When FTP
  (GH-948) Ensure passwords / keys are not logged
  (GH-952) Get-ChocolateyWebFile enhancements
  (doc) update generated docs
  (maint) formatting
  (docs) move GenerateDocs.ps1 / update
  (GH-932) Do not set unknown checksum to 'md5'
  (GH-719) Reset ServerCertificateValidationCallback
  (GH-305) add MSP/MSU installer types
  (GH-305) update exitcodes to long
  (GH-954) Pending fails when lib does not exist
  (GH-950) Install-ChocolateyPackage - UseOriginalLocation
  (maint) formatting
  (GH-922) Automatically determine checksum type
  (maint) fixes for shimgen
  (GH-948) Do not log sensitive arguments
  ...
@eirikatdips eirikatdips mentioned this issue Sep 12, 2016
Closed
@ferventcoder
Copy link
Member

Merged into stable at 315a882 and will be included in 0.10.1.

@ferventcoder ferventcoder changed the title Request: switch to apply package parameters to dependent packages Option to apply package parameters / install arguments to dependent packages Sep 16, 2016
ferventcoder added a commit that referenced this issue Sep 17, 2016
@ferventcoder
(GH-839) More switch names for dependency apply
b7974d5 
When specifying an apply of install arguments and package parameters,
it would be best to have multiple ways to specify those options. Add
shorter option names
ferventcoder added a commit that referenced this issue Sep 17, 2016
@ferventcoder
Merge branch 'stable'
19cdf4b 
* stable:
  (GH-934) Support Paths > 260 Characters
  (GH-943) Skip Locked Pending Files
  (GH-943) Lock Pending File Until Operation Completes
  (GH-943) IFileSystem - Open File Exclusively
  (GH-839) More switch names for dependency apply
@DJCrashdummy DJCrashdummy mentioned this issue May 20, 2021
Closed
@DJCrashdummy
Copy link

i'm not sure if i'm embarrassing my self right now (i'm just a casual windows user), so please bear with me.

is there a way to specify --apply-package-parameters-to-dependencies (and --apply-package-parameters-to-dependencies) in a config file just for certain packages to be on the safe side?
...or do i really have to split all these packages from my install.config into a separate parameters_passthrough.config where i specify --apply-package-parameters-to-dependencies (and --apply-package-parameters-to-dependencies) in the command because it applies to all of its contained packages?!?

@TheCakeIsNaOH
Copy link
Member

I do not think that option has been added to .config files yet.
#886

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ferventcoder ferventcoder

Labels
5 - Released Customer Improvement
Projects
None yet
Milestone
0.10.1
Development

No branches or pull requests
5 participants
@ferventcoder @gep13 @eirikatdips @DJCrashdummy @TheCakeIsNaOH