Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore Valid Package Exit Codes for Real #827

Closed
ferventcoder opened this issue Jun 23, 2016 · 4 comments
Closed

Ignore Valid Package Exit Codes for Real #827

ferventcoder opened this issue Jun 23, 2016 · 4 comments
Assignees
@ferventcoder
Labels
5 - Released Bug Priority_HIGH
Milestone
0.9.10.3

Comments

@ferventcoder
Copy link
Member

@mwrock discovered that attempting to ignore package exit codes still returns the exit codes.
@ferventcoder ferventcoder added this to the 0.9.10.3 milestone Jun 23, 2016
@ferventcoder ferventcoder self-assigned this Jun 23, 2016
@mwrock
Copy link
Member

mwrock commented Jun 23, 2016

Here is a transcript of an install with --debug https://gist.github.com/mwrock/00161c222cce9a0efd222c5eb8f38604

ferventcoder added a commit that referenced this issue Jun 23, 2016
@ferventcoder
(GH-827) No really, ignore package exit codes
713df97 
If it is a valid exit code, choco used to set the exit code to zero.
Otherwise the exit code was set to 1. That behavior needs to continue to
be that way for the exit code of choco.exe when ignoring package exit
codes.
ferventcoder added a commit that referenced this issue Jun 23, 2016
@ferventcoder
Merge branch 'stable'
a10d936 
* stable:
  (GH-827) No really, ignore package exit codes
@ferventcoder
Copy link
Member Author

And this will be out in a little while.

@ferventcoder
Copy link
Member Author

Today likely, possibly tomorrow

@mwrock mwrock mentioned this issue Jun 23, 2016
Closed
@ferventcoder ferventcoder changed the title Ignore ValidPackage Exit Codes For Real Ignore ValidPackage Exit Codes for Real Jun 23, 2016
@ferventcoder ferventcoder mentioned this issue Jun 23, 2016
Closed
@ferventcoder
Copy link
Member Author

ferventcoder commented Jun 23, 2016 •
edited
Loading

@mwrock Just pushed. Should be live within two hours. You can upgrade to it right now without waiting by specifying choco upgrade chocolatey --version 0.9.10.3

@ferventcoder ferventcoder changed the title Ignore ValidPackage Exit Codes for Real Ignore Valid Package Exit Codes for Real Jun 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ferventcoder ferventcoder

Labels
5 - Released Bug Priority_HIGH
Projects
None yet
Milestone
0.9.10.3
Development

No branches or pull requests
3 participants
@ferventcoder @mwrock @gep13