Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Getting LCID doesn't work properly with the built-in PowerShell Host #741

Closed
ferventcoder opened this issue May 21, 2016 · 7 comments
Closed

Getting LCID doesn't work properly with the built-in PowerShell Host #741

ferventcoder opened this issue May 21, 2016 · 7 comments
Assignees
@ferventcoder
Labels
5 - Released Bug PowerShell Internal Host Priority_HIGH
Milestone
0.9.10

Comments

@ferventcoder
Copy link
Member

$LCID = (Get-Culture).LCID does not appear to produce the proper LCID for a package when running under the PowerShell Internal Host.

The BeyondCompare package is a good one to test.
@ferventcoder ferventcoder added this to the 0.9.10 milestone May 21, 2016
@flcdrg
Copy link
Member

flcdrg commented May 23, 2016

FYI @shiftkey

@ferventcoder
Copy link
Member Author

I think I know what this is.

@ferventcoder
Copy link
Member Author

I think I have this fixed, but I'm going to need some help getting it validated.

@shiftkey
Copy link

@ferventcoder is there anything I can help with?

@ferventcoder
Copy link
Member Author

Possibly - I think I have a way to verify this though, I spoke a little too soon! I will keep you in the loop if I run into issues!

ferventcoder added a commit to ferventcoder/choco that referenced this issue May 25, 2016
@ferventcoder
(chocolateyGH-741) Ensure CultureInfo with PowerShell Host
152d83e 
When using the built-in posh host, the culture information that is
returned should be the user's culture info, so that gathering the LCID
for language settings in packages works appropriately. Without this
fix, everyone will be given the invariant culture (127), which could
cause problems across every package that detects locale.
@ferventcoder
Copy link
Member Author

Yup, good to go.

@ferventcoder
Copy link
Member Author

Pushed a new version of the beta with just this change - should be available in the next two hours - if you need to get it before then, use choco upgrade chocolatey -version 0.9.10-beta-20160524

@ferventcoder ferventcoder self-assigned this May 25, 2016
ferventcoder added a commit that referenced this issue May 28, 2016
@ferventcoder
Merge branch 'stable'
1213a58 
* stable:
  (GH-741) Ensure CultureInfo with PowerShell Host
  (GH-641) Add more installer types
  (maint) only log debug verbose for event messages
  (GH-354) Fix MSI template SilentArgs
  (maint) Fail on new --file when not supported
  (GH-641) add temp location
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ferventcoder ferventcoder

Labels
5 - Released Bug PowerShell Internal Host Priority_HIGH
Projects
None yet
Milestone
0.9.10
Development

No branches or pull requests
4 participants
@ferventcoder @shiftkey @flcdrg @gep13