If a nupkg/nuspec is corrupt, do not fail trying to read it

[ferventcoder]

There may have been a network issue. Related to #198.

Zero byte nupkgs or nuspec files will give an issue like "Root element is missing".

Workaround

Find and remove the zero byte file and that should fix the issue. This is a manual workaround until Chocolatey can handle this.

[ferventcoder]

@DarwinJS can you get me details on this one again? I just attempted to recreate this and was unable to.

[DarwinJS]

If I remember correctly the file was truncated and the install failed.
Then when trying to install again it would not redownload (because the file
passes an existence check?), but then would choke on the incomplete file.
So kind of a catch 22 if you don't know what to delete. Maybe it is
important that the type of file corruption is a truncation?

D.
On May 30, 2016 3:42 PM, "Rob Reynolds" [email protected] wrote:

@DarwinJS https://github.com/DarwinJS can you get me details on this
one again? I just attempted to recreate this and was unable to.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#717 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/ALD1hnHHAHS-YC0vaj82P84egnpimxkdks5qGz3AgaJpZM4IUDoO
.

[marcinbojko]

Hit by the same issue - out of space on one of dev servers, downloaded nupkg/nuspec files were broken (0 in lenght).

[masgo]

I suggest starting with a more useful error message. "Root element is missing" is not very helpful. Maybe make it something like: "Root element is missing. Probably the nupkg file is broken. You can try to delete it by (add some command to chocolatey which just deletes everything) and start over." This would solve the issues for many users.

Later™, you could do a more sophisticaed/automated solution.

[ferventcoder]

@masgo I completely agree with better/more actionable errors - it's a constant struggle when you use libraries that don't share this same idea.

[ferventcoder]

Note for the implementer - take a look at #1829 as well.

[jawn]

To make it easier to discover, I documented the issue and workaround on superuser.com.

[ferventcoder]

Thanks for doing that @jawn!

[s-celles]

For those who also encounter this zero size file bug, you can remove them using this PowerShell command.

ChildItem C:\ProgramData\chocolatey\lib\*\*.nu* | where Length -eq 0 | Del

[Chirishman]

Ran into this again today when trying to upgrade the mediainfo package, kept getting

2022-02-08 04:29:20,338 18004 [ERROR] - chocolatey not upgraded. An error occurred during installation: Unable to read package from path 'imagemagick.app\imagemagick.app.nupkg'.

Then when I removed the imagemagick.app folder from lib I started getting "root element is missing" until I ran @scls19fr's cleanup script.

+1 to this being handled more gracefully