Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Force reinstall, force upgrade, and uninstall should delete the download cache #590

Closed
ferventcoder opened this issue Jan 29, 2016 · 1 comment
Closed

Force reinstall, force upgrade, and uninstall should delete the download cache #590

ferventcoder opened this issue Jan 29, 2016 · 1 comment
Assignees
@ferventcoder
Labels
5 - Released Breaking Change Bug
Milestone
0.9.10

Comments

@ferventcoder
Copy link
Member

No description provided.

@ferventcoder ferventcoder self-assigned this Jan 29, 2016
@ferventcoder ferventcoder added this to the 0.9.10 milestone Jan 29, 2016
@ferventcoder ferventcoder changed the title Force reinstall / upgrade should also delete the cache Force reinstall, force upgrade and uninstall should delete the cache Jan 29, 2016
@ferventcoder
Copy link
Member Author

There is a small possibility here folks will need to update their cache location so provide notice. If they've specified it, we no longer use a chocolatey subdirectory for the cache, only when it uses the TEMP variable.

@ferventcoder ferventcoder changed the title Force reinstall, force upgrade and uninstall should delete the cache Force reinstall, force upgrade, and uninstall should delete the cache Jan 29, 2016
@ferventcoder ferventcoder changed the title Force reinstall, force upgrade, and uninstall should delete the cache Force reinstall, force upgrade, and uninstall should delete the download cache Jan 29, 2016
ferventcoder added a commit to ferventcoder/choco that referenced this issue Jan 29, 2016
@ferventcoder
(chocolateyGH-590) Uninstall Cleanup Cache / Delete on Force
024aba9 
If forcing a reinstall or forcing an upgrade, the package cache should
be deleted if it is found. Always remove the package cache on uninstall.
ferventcoder added a commit to ferventcoder/choco that referenced this issue Jan 29, 2016
@ferventcoder
(chocolateyGH-590) Explicit Cache - No chocolatey subdirectory
cd21a68 
An explicit cache directory should not use a "chocolatey" subdirectory.
The use of the chocolatey subdirectory should only occur if choco uses
the TEMP location.
ferventcoder added a commit that referenced this issue Jan 30, 2016
@ferventcoder
(GH-590) Uninstall Cleanup Cache / Delete on Force
353c2da 
If forcing a reinstall or forcing an upgrade, the package cache should
be deleted if it is found. Always remove the package cache on uninstall.
ferventcoder added a commit that referenced this issue Jan 30, 2016
@ferventcoder
(GH-590) Explicit Cache - No chocolatey subdirectory
a9519b5 
An explicit cache directory should not use a "chocolatey" subdirectory.
The use of the chocolatey subdirectory should only occur if choco uses
the TEMP location.
ferventcoder added a commit that referenced this issue Jan 30, 2016
@ferventcoder
Merge branch 'ticket/stable/pro-hooks' into stable
fb46b9e 
* ticket/stable/pro-hooks: (25 commits)
  (GH-584) Build virus check configuration
  (GH-584) Make empty Get-VirusCheckValid call
  (GH-583) Mark command methods virtual
  (specs) Try twice to delete .chocolatey directory
  (docs) update CHANGELOG / nuspec
  (GH-535) Tags before summary in nuspec template
  (GH-479) Remove NuGet cache of package
  (GH-584) Reinstall should use available package
  (GH-590) Explicit Cache - No chocolatey subdirectory
  (GH-584) Set Env Variable for PowerShell Host
  (maint) formatting
  (GH-590) Uninstall Cleanup Cache / Delete on Force
  (GH-585) Force should allow downgrade
  (GH-584) Hook for loading licensed posh extensions
  (GH-584) License name - Redact @Domain of email
  (GH-584) Load licensed version
  (GH-584) Simple injector load component registries
  (GH-584) Get version info for other assemblies
  (GH-584) Assembly adapter enhancements
  (GH-583) unseal commands
  ...
ferventcoder added a commit that referenced this issue Jan 30, 2016
@ferventcoder
Merge branch 'stable'
9f34984 
* stable: (26 commits)
  (GH-584) Build virus check configuration
  (GH-584) Make empty Get-VirusCheckValid call
  (GH-583) Mark command methods virtual
  (specs) Try twice to delete .chocolatey directory
  (docs) update CHANGELOG / nuspec
  (GH-535) Tags before summary in nuspec template
  (GH-479) Remove NuGet cache of package
  (GH-584) Reinstall should use available package
  (GH-590) Explicit Cache - No chocolatey subdirectory
  (GH-584) Set Env Variable for PowerShell Host
  (maint) formatting
  (GH-590) Uninstall Cleanup Cache / Delete on Force
  (GH-585) Force should allow downgrade
  (GH-584) Hook for loading licensed posh extensions
  (GH-584) License name - Redact @Domain of email
  (GH-584) Load licensed version
  (GH-584) Simple injector load component registries
  (GH-584) Get version info for other assemblies
  (GH-584) Assembly adapter enhancements
  (GH-583) unseal commands
  ...
@ferventcoder ferventcoder mentioned this issue Jun 18, 2016
Closed
ferventcoder added a commit that referenced this issue Jun 19, 2016
@ferventcoder
(GH-813) Fix double chocolatey logging folder
ae2e857 
When using $env:TEMP in versions of Chocolatey less than 0.9.10.x, TEMP
did not include "chocolatey". However, due to GH-590 and a9519b5, this
is now causing issues when someone has setup an MSI logging file with
`$env:TEMP\chocolatey\packagename\packagename.msi.log`. The package TEMP
value evaluates to `$env:TEMP\chocolatey` (actual TEMP variable), which
results in
`$env:TEMP\chocolatey\chocolatey\packagename\packagename.msi.log`. This
breaks because that folder doesn't get created.

Instead look for double chocolatey folder in actual evaluation and
handle that to ensure compatibility with packages.
ferventcoder added a commit that referenced this issue Sep 2, 2016
@ferventcoder
(GH-908) Fix Double Chocolatey folder for $file
602fd0f 
For GH-813 (ae2e857), the double `chocolatey\chocolatey` folder was
removed from `$silentArgs` and `$additionalInstallArgs`, but `$file`
was missed. These changes were originally necessary due to changes in
GH-590 (a9519b5). Ensure that $file is also set properly so it no
longer uses a double chocolatey folder.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ferventcoder ferventcoder

Labels
5 - Released Breaking Change Bug
Projects
None yet
Milestone
0.9.10
Development

No branches or pull requests
2 participants
@ferventcoder @gep13