The handle is invalid - when output is being redirected and a package attempts to write to a filestream #572
Comments
|
See https://chocolatey.org/packages/instantwordpress/4.5.0 You can repro as simply as trying to write a file from a write-host or echo. echo '' >"$($exe.FullName).gui" |
ferventcoder
changed the title
ferventcoder
changed the title
|
Sort of related - #666 |
ferventcoder
added a commit
that referenced
this issue
Mar 29, 2016
When running PowerShell but redirecting the output and a package attempts to write to a filestream, it runs into an age old PowerShell bug "The OS handle's position is not what FileStream expected. Do not use a handle simultaneously in one FileStream and in Win32 code or another FileStream. This may cause data loss." Usually this bug is known to affect PowerShell v2, but when running PowerShell with System.Management.Automation, it appears to affect more versions (it has been seen in PowerShell v3 and v4). Running this in newer versions of PowerShell has been tested not to cause any adverse affects, so it is presumed to be safe. The fix comes from http://www.leeholmes.com/blog/2008/07/30/workaround-the-os-handles-position-is-not-what-filestream-expected/ plus information in the comments that actually allows it to work.
ferventcoder
added a commit
that referenced
this issue
Mar 29, 2016
* stable: (GH-460) Amended Template (GH-623) Extract Nuspec on Install (GH-674)(GH-672) Color Overrides / Fix Write-Host (GH-181) log selection to log file only (GH-181)(GH-184) Short prompt/Prompt character (GH-675) Template include LICENSE/VERIFICATION (GH-258) Rename zip to detector.zip (GH-572) Fix: The handle is invalid - Output Redirection (maint) comments (GH-667) Provide How To Add Profile Manually (GH-667) PowerShell Custom Host - Set $Profile (GH-666) pass Write-ChocolateyError message param (GH-673) Ensure Get-BinRoot Warning is Shown (GH-666) setup logs colored write-host w/fallback
|
This is not quite resolved. And not that easy to reproduce outside of building and running through puppet or vagrant. |
ferventcoder
added a commit
that referenced
this issue
Apr 2, 2016
When output is being redirected, `IConsole` needs to be able to handle that as most of `System.Console` throws errors on methods and properties that would normally be available. Detect if output is being redirected by checking the StdHandle against FileType. Additionally, handle certain calls to find out about console related information.
ferventcoder
added a commit
that referenced
this issue
Apr 2, 2016
When redirecting output, if anything attempts to write to the file stream, it causes this error. The error is related to using Console related properties and values in `PoshHostRawUserInterface`. The fix is to use the `IConsole` adapter instead of calling `System.Console` directly, as `IConsole` already has the ability to handle redirected output.
ferventcoder
added a commit
that referenced
this issue
Apr 2, 2016
Getting the PowerShell internal host running on the spec tests required providing `config.Information.ChocolateyVersion` and handling redirected console output as part of GH-572.
|
And finally, this is good to go! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Related to #526 - redirecting output to a filestream seems to cause issues with the PowerShell Host. This is related to the age old POSH bug (The OS handle's position is not what FileStream expected. Do not use a handle simultaneously in one FileStream and in Win32 code or another FileStream. This may cause data loss) - read more about it at chocolatey-archive/puppet-chocolatey#18
Workaround: use the switch
--use-system-powershelluntil this issue is resolved.Update: This is actually related to
PSHostRawUserInterface's use of Console. There are some things that need to be done differently with console when output is being redirected.The text was updated successfully, but these errors were encountered: